-
Notifications
You must be signed in to change notification settings - Fork 23
fixing out of date guidance #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated contributing guidelines to clarify the process for editing AEP rules and submitting PRs. Removes out-of-date information about the site generator and points to our dedicated repo.
|
@rambleraptor DYK if the formatting guidance at the end of this document still applies? If not, I'll take it out as well. |
slack and gcal moved from readme
Rather than add clicks to journeys (by visiting a .md file and then the website), this helps people get where they need to be faster.
toumorokoshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks
|
please make sure lint passed before merging! |
adds back instructions for the script for running locally and fixes the broken `fix.py` link
Because I was working on a Chromebook, I didn't have an easy way to run the linter on markdown, and the GitHub workflow doesn't give enough insight into what violations it encountered. Luckily there is an online version of [Prettier](https://prettier.io/playground), so I've used that.
|
@earth2marsh can you run |
Updated contributing guidelines to clarify the process for editing AEP rules and submitting PRs. Removes out-of-date information about the site generator and points to our dedicated repo.
🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for
contributing to this repository.
General
references AEPs
correctly.
(run
make lint)💝 Thank you!