Skip to content

Conversation

@earth2marsh
Copy link
Contributor

Updated contributing guidelines to clarify the process for editing AEP rules and submitting PRs. Removes out-of-date information about the site generator and points to our dedicated repo.

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for
contributing to this repository.

General

💝 Thank you!

Updated contributing guidelines to clarify the process for editing AEP rules and submitting PRs. Removes out-of-date information about the site generator and points to our dedicated repo.
@earth2marsh earth2marsh requested a review from a team as a code owner November 22, 2025 23:53
@earth2marsh
Copy link
Contributor Author

@rambleraptor DYK if the formatting guidance at the end of this document still applies? If not, I'll take it out as well.

slack and gcal moved from readme
Rather than add clicks to journeys (by visiting a .md file and then the website), this helps people get where they need to be faster.
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@toumorokoshi
Copy link
Member

please make sure lint passed before merging!

adds back instructions for the script for running locally and fixes the broken `fix.py` link
Because I was working on a Chromebook, I didn't have an easy way to run the linter on markdown, and the GitHub workflow doesn't give enough insight into what violations it encountered. 

Luckily there is an online version of [Prettier](https://prettier.io/playground), so I've used that.
@rambleraptor
Copy link
Member

@earth2marsh can you run npm run lint to fix the linter issues? You should be free to merge after that.

@earth2marsh earth2marsh merged commit 667b74b into main Dec 4, 2025
2 checks passed
@earth2marsh earth2marsh deleted the contributing branch December 4, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants