Adjust ae_determine_receptor_ids_from_receptor_with_radius#21
Merged
Conversation
Function is adjusted to no longer return 0 as receptor_id. Turns out, with a receptor_id of 3907993, and a radius of 1409, the adjusted unittest would fail. This because 0 would be returned, and since that doesn't really hold with the assumption of the test adjusted the function to void this (0 isn't a receptor ID we want in any case). Unfortunately the test didn't supply the radius directly and is using random numbers, so had to create a query that would do all radius values between 1 and 1530 to figure out the value that was causing the error...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function is adjusted to no longer return 0 as receptor_id.
Turns out, with a receptor_id of 3907993, and a radius of 1409, the adjusted unittest would fail. This because 0 would be returned, and since that doesn't really hold with the assumption of the test adjusted the function to void this (0 isn't a receptor ID we want in any case).
Unfortunately the test didn't supply the radius directly and is using random numbers, so had to create a query that would do all radius values between 1 and 1530 to figure out the value that was causing the error...