Add ClickHouse + jOOQ and implement Catalog- and MatrixService#4
Merged
Conversation
BertScholten
requested changes
May 28, 2026
Member
BertScholten
left a comment
BertScholten
left a comment
There was a problem hiding this comment.
Looks quite good, do have some suggestions that might not be for this PR.
- Move ResolvedMatrixQuery to matrix.model package - Let ResolvedMatrixQuery invert the lookup maps - Remove Map.copyOf
Change types of height, heat content and spread
BertScholten
requested changes
May 29, 2026
Member
BertScholten
left a comment
BertScholten
left a comment
There was a problem hiding this comment.
Think terraform configuration has to be updated as well.
JacobusXIII
force-pushed
the
implement_clickhouse
branch
from
73e1822 to
679058e
Compare
JacobusXIII
force-pushed
the
implement_clickhouse
branch
from
679058e to
1484651
Compare
JacobusXIII
force-pushed
the
implement_clickhouse
branch
from
54f5782 to
d15a30c
Compare
Contributor
Author
|
ClickHouse can be deployed now. To test the endpoints, I have created a temporary flyway patch with dummy data. |
JacobusXIII
force-pushed
the
implement_clickhouse
branch
from
cd281a8 to
bdac7fd
Compare
BertScholten
reviewed
Jun 1, 2026
This reverts commit fd8185b.
Run *IT.java using mvn verify -Pintegration-tests
JacobusXIII
force-pushed
the
implement_clickhouse
branch
from
d1096e3 to
b1c3a19
Compare
BertScholten
approved these changes
Jun 1, 2026
JacobusXIII
force-pushed
the
implement_clickhouse
branch
2 times, most recently
from
e9e26e3 to
39029ff
Compare
JacobusXIII
force-pushed
the
implement_clickhouse
branch
from
39029ff to
01605cc
Compare
BertScholten
reviewed
Jun 3, 2026
JacobusXIII
force-pushed
the
implement_clickhouse
branch
5 times, most recently
from
45bc491 to
2277db8
Compare
And don't run integrationtests on pullrequestchecker, only on QA
JacobusXIII
force-pushed
the
implement_clickhouse
branch
from
2277db8 to
48737c4
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.