AER-4020 Fixes to guarding against messages retreived after restart#121
Merged
Conversation
Member
Hilbrand
commented
May 19, 2026
Hilbrand
commented
- In QueueWatchDog it should clear the runningTasks known on reset otherwise each time this method is subsequentially called it will retrigger the reset.
- The keeping track of dispatchedTasks that was in PerformanceMetricsReporter should have been moved to TaskManagerMetricsRegister because there the register call has been moved to.
- Added extra guard in LoadMetric to make sure it would never become negative.
- In QueueWatchDog it should clear the runningTasks known on reset otherwise each time this method is subsequentially called it will retrigger the reset. - The keeping track of dispatchedTasks that was in PerformanceMetricsReporter should have been moved to TaskManagerMetricsRegister because there the register call has been moved to. - Added extra guard in LoadMetric to make sure it would never become negative.
JornC
approved these changes
May 19, 2026
JornC
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.