Fix for issue where curranking would be float, yielding an error at np.bincount in recovery.rcc2d()#7
Open
jberkh wants to merge 1 commit intoaertslab:mainfrom
Open
Fix for issue where curranking would be float, yielding an error at np.bincount in recovery.rcc2d()#7jberkh wants to merge 1 commit intoaertslab:mainfrom
jberkh wants to merge 1 commit intoaertslab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue in pyscenic, where some values for pyscenic.prune.prun2df arguments auc_threshold and nes_threshold, it gave the following error:
The error arises from the need for an integer matrix as input for np.bincount. Apparently, curranking becomes a float matrix at certain values for auc_threshold and nes_threshold. The explicit cast to int fixes this issue.
NB: I'm unsure if the broader context of the code would necessitate calling np.rint() before casting to int. If so, please edit the PR where necessary.