docs: sync AgentShield adapter evidence#2017
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR synchronizes multiple documentation surfaces across the ECC repository to incorporate AgentShield PR ChangesDocumentation Synchronization for Zed/VS Code Adapter Coverage
Possibly Related PRs
Poem
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/releases/2.0.0-rc.1/publication-evidence-2026-05-19.md`:
- Around line 77-79: The discussion-count in the queue table is inconsistent
with the recorded resolution of Discussion `#2015`; update the earlier queue table
row that lists total discussions (the one showing "59 discussions after `#2003`")
to decrement the count to reflect `#2015` being answered/accepted and adjust its
timestamp to match the May 20 `#2015` update (use the same ISO timestamp format
shown for the ECC platform audit entries), and ensure any inline mention of
Discussion `#2015` in the table text or footnotes matches the phrasing "answered
and marked accepted" used later in the evidence section.
In `@docs/security/supply-chain-incident-response.md`:
- Around line 29-31: The Immediate Response "Remove persistence hooks" checklist
is missing Zed-specific cleanup; update that section to explicitly remove Zed
persistence files (e.g., `.zed/tasks.json` and any `.zed/*` configs), delete or
quarantine Zed workspace settings, and stop/uninstall any associated agents or
launch services (similar to `gh-token-monitor` LaunchAgent/systemd steps), then
re-run token rotation and verification; reference the existing examples for
`.claude/settings.json` and `.vscode/tasks.json` to mirror wording and order so
Zed entries are covered in the containment checklist.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 15f05d5c-55dd-4658-a04f-1b7d679acfbb
📒 Files selected for processing (4)
docs/ECC-2.0-GA-ROADMAP.mddocs/releases/2.0.0-rc.1/preview-pack-manifest.mddocs/releases/2.0.0-rc.1/publication-evidence-2026-05-19.mddocs/security/supply-chain-incident-response.md
Comment on lines
77
to
+79
| | ECC discussion queue | Discussion #2015 was answered and marked accepted with conservative setup guidance: do not install in `C:\`; use a normal workspace; install `ecc@ecc` once through the Claude plugin marketplace; copy only needed rule folders when using manual rules; do not stack plugin plus full manual install. | | ||
| | ECC platform audit | `node scripts/platform-audit.js --json` at `2026-05-20T00:25:38Z` returned ready true with 0 open PRs, 0 open issues, 0 discussion maintainer-touch gaps, 0 answerable Q&A gaps, 0 conflicting PRs, and 0 dirty blockers across `affaan-m/ECC`, `affaan-m/agentshield`, `affaan-m/JARVIS`, `ECC-Tools/ECC-Tools`, and `ECC-Tools/ECC-website`. | | ||
| | ECC platform audit recheck | `npm run platform:audit -- --json` at `2026-05-20T00:42:11Z` returned ready true with 0 open PRs, 0 open issues, 0 discussion maintainer-touch gaps, 0 answerable Q&A gaps, 0 conflicting PRs, 0 GitHub errors, and 0 dirty blockers across the same tracked repo set after AgentShield #94 merged. | |
Contributor
There was a problem hiding this comment.
Align discussion-count evidence with the May 20 #2015 update.
This section records Discussion #2015 as answered/accepted, but the earlier queue table in the same file still says 59 discussions after #2003. Please update the count/timestamp so the evidence narrative is internally consistent.
Proposed doc fix
-| Discussion audit through platform audit | `node scripts/platform-audit.js --json` | `affaan-m/ECC` discussions enabled; 59 sampled after `#2003` AURA integration proposal; 0 needing maintainer touch; 0 answerable without accepted answer |
+| Discussion audit through platform audit | `node scripts/platform-audit.js --json` | `affaan-m/ECC` discussions enabled; 60 sampled after `#2003` plus `#2015` acceptance; 0 needing maintainer touch; 0 answerable without accepted answer |🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/releases/2.0.0-rc.1/publication-evidence-2026-05-19.md` around lines 77
- 79, The discussion-count in the queue table is inconsistent with the recorded
resolution of Discussion `#2015`; update the earlier queue table row that lists
total discussions (the one showing "59 discussions after `#2003`") to decrement
the count to reflect `#2015` being answered/accepted and adjust its timestamp to
match the May 20 `#2015` update (use the same ISO timestamp format shown for the
ECC platform audit entries), and ensure any inline mention of Discussion `#2015`
in the table text or footnotes matches the phrasing "answered and marked
accepted" used later in the evidence section.
Comment on lines
+29
to
+31
| `.claude/settings.json`, VS Code `.vscode/tasks.json`, Zed | ||
| `.zed/tasks.json`, and OS-level `gh-token-monitor` LaunchAgent/systemd | ||
| services. Some variants add |
Contributor
There was a problem hiding this comment.
Add Zed persistence cleanup steps in the containment checklist.
The runbook now flags Zed persistence indicators, but the Immediate Response “Remove persistence hooks” list still omits Zed file cleanup. During an incident, that can leave persistence in place after token rotation.
Proposed runbook patch
4. Remove persistence hooks before token revocation:
- `~/.claude/settings.json` `SessionStart` hooks and adjacent
`router_runtime.js` / `setup.mjs` payload files;
- `.vscode/tasks.json` folder-open tasks and adjacent payload files;
+ - `.zed/tasks.json`, `.zed/settings.json`, and adjacent `.zed/setup.mjs` / hook payload files;
- `~/Library/LaunchAgents/com.user.gh-token-monitor.plist`;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/security/supply-chain-incident-response.md` around lines 29 - 31, The
Immediate Response "Remove persistence hooks" checklist is missing Zed-specific
cleanup; update that section to explicitly remove Zed persistence files (e.g.,
`.zed/tasks.json` and any `.zed/*` configs), delete or quarantine Zed workspace
settings, and stop/uninstall any associated agents or launch services (similar
to `gh-token-monitor` LaunchAgent/systemd steps), then re-run token rotation and
verification; reference the existing examples for `.claude/settings.json` and
`.vscode/tasks.json` to mirror wording and order so Zed entries are covered in
the containment checklist.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/security/supply-chain-incident-response.md">
<violation number="1" location="docs/security/supply-chain-incident-response.md:29">
P3: Add `.zed/tasks.json` (and adjacent payload files) to the Immediate Response step 4 cleanup list to match the newly added Zed IOC indicator.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| - The live IOC set includes persistence through Claude Code | ||
| `.claude/settings.json`, VS Code `.vscode/tasks.json`, and OS-level | ||
| `gh-token-monitor` LaunchAgent/systemd services. Some variants add | ||
| `.claude/settings.json`, VS Code `.vscode/tasks.json`, Zed |
Contributor
There was a problem hiding this comment.
P3: Add .zed/tasks.json (and adjacent payload files) to the Immediate Response step 4 cleanup list to match the newly added Zed IOC indicator.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/security/supply-chain-incident-response.md, line 29:
<comment>Add `.zed/tasks.json` (and adjacent payload files) to the Immediate Response step 4 cleanup list to match the newly added Zed IOC indicator.</comment>
<file context>
@@ -26,8 +26,9 @@ credentials:
- The live IOC set includes persistence through Claude Code
- `.claude/settings.json`, VS Code `.vscode/tasks.json`, and OS-level
- `gh-token-monitor` LaunchAgent/systemd services. Some variants add
+ `.claude/settings.json`, VS Code `.vscode/tasks.json`, Zed
+ `.zed/tasks.json`, and OS-level `gh-token-monitor` LaunchAgent/systemd
+ services. Some variants add
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.zed/tasks.jsonpersistence coverageVerification
npm run preview-pack:smoke -- --format jsonnpm run platform:audit -- --jsongit diff --check HEAD~1..HEADnpm run release:approval-gate -- --format jsonexits 2 as expected: 4/6 pass, owner decisions and live URL ledger still intentionally blockedSummary by cubic
Synced AgentShield PR #94 evidence into the GA roadmap and rc.1 publication ledger, adding Zed/VS Code adapter coverage (.zed/settings.json, .zed/tasks.json) and flagging .zed/setup.mjs under the tool‑persistence IOC rule. Also linked updates to Linear ITO-49/project comments and updated the preview-pack manifest and supply‑chain incident guide to include Zed indicators.
Written for commit a5a57b5. Summary will update on new commits. Review in cubic
Summary by CodeRabbit