Adapt to https://github.com/math-comp/math-comp/pull/1456#214
Merged
t6s merged 1 commit intoaffeldt-aist:masterfrom Apr 5, 2026
Merged
Adapt to https://github.com/math-comp/math-comp/pull/1456#214t6s merged 1 commit intoaffeldt-aist:masterfrom
t6s merged 1 commit intoaffeldt-aist:masterfrom
Conversation
And cleanup of previous overlay.
21 tasks
Collaborator
|
It's interesting that most of the required changes are just the loading order of realType_ext. Were those early |
Contributor
Author
|
The previous Require were for a previous version of math-comp/math-comp#1456 whose compatibility with already released versions of Stdlib was worse than the current version (the order of importing some files with some |
Contributor
Author
t6s
approved these changes
Apr 5, 2026
Collaborator
|
Looks good, and the CI is indeed green as much as external dependencies permit (i.e., only 9.1 & interval is failing). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt to math-comp/math-comp#1456 and cleanup of previous overlay.