feat: apply production learnings from pbx and vagrant-story#21
Merged
Conversation
Add Button loading state with width preservation, extra button sizes (xs, icon-xs, icon-sm, icon-lg), auth re-validation on tab focus via visibilitychange, and name field to auth context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadingprop to Button with spinner and width preservation (prevents layout shift)xs,icon-xs,icon-sm,icon-lgvisibilitychange(catches expired sessions when user returns to tab)namefield to auth context and/auth/meresponse typeTest plan