refactor: move error and not-found components to router defaults#26
Merged
Conversation
Register the error boundary and not-found component on the router via defaultErrorComponent and defaultNotFoundComponent instead of on the root route. This lets the boundary catch errors thrown by the root route itself, which the route-level errorComponent cannot since it is hosted inside the same route. Also renames RootErrorComponent to ErrorBoundary so the export matches its filename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultErrorComponent/defaultNotFoundComponentinmain.tsxinstead oferrorComponent/notFoundComponenton__root.tsx. This lets the boundary catch errors thrown by the root route itself — the route-level prop can't, since the boundary is hosted inside the same route it's protecting.RootErrorComponent→ErrorBoundaryso the export matches theerror-boundary.tsxfilename (easier IDE jump-to-symbol and grep).errorComponent/notFoundComponentprops still work for routes that want to override (e.g., a dashboard with inline error UI that preserves the nav).Test plan
pnpm dev— app boots normally, no console errors/does-not-exist) — 404 page renderspnpm buildandpnpm test:runboth pass