Skip to content

fix: read GTK4 a11y trees by pinning proxy destination (#31) #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avifenesh merged 1 commit into from
Jun 21, 2026
Merged

fix: read GTK4 a11y trees by pinning proxy destination (#31) #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed
- GTK4 applications (Nautilus, Text Editor, baobab, and others) now return their
full accessibility tree instead of a single `role: "unknown"` root with
`child_count: 0`. Reads were routed through the `atspi` `P2P` trait's
`object_as_accessible`, whose no-peer fallback builds a proxy with a path but
no destination; on the shared a11y bus that fails with `ServiceUnknown` for
any app that does not advertise a peer-to-peer bus address. Modern GTK4 apps
do not implement the legacy `GetApplicationBusAddress`, so they hit the broken
fallback while GTK3/Chromium/Electron apps kept working. Reads now use
`ObjectRefExt::as_accessible_proxy`, which always pins the destination to the
object's bus name. (#31)

## [0.2.8] - 2026-06-17

### Changed
Expand Down
39 changes: 29 additions & 10 deletions src/atspi_tree.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
use crate::diagnostics::hydrate_session_bus_env;
use anyhow::{anyhow, Context, Result};
use atspi::{
connection::P2P,
proxy::{accessible::AccessibleProxy, proxy_ext::ProxyExt},
proxy::{
accessible::{AccessibleProxy, ObjectRefExt},
proxy_ext::ProxyExt,
},
AccessibilityConnection, CoordType, ObjectRef, ObjectRefOwned, StateSet,
};
use schemars::JsonSchema;
Expand Down Expand Up @@ -105,7 +107,7 @@ pub async fn list_accessible_apps(limit: usize) -> Result<Vec<AccessibleAppSumma
let mut apps = Vec::new();

for object_ref in roots.into_iter().take(limit) {
if let Ok(proxy) = conn.object_as_accessible(&object_ref).await {
if let Ok(proxy) = open_accessible(&conn, &object_ref).await {
apps.push(read_app_summary(&proxy, &object_ref, dbus.as_ref()).await);
}
}
Expand Down Expand Up @@ -135,7 +137,7 @@ pub async fn snapshot_tree(
break;
}

let Ok(proxy) = conn.object_as_accessible(&object_ref).await else {
let Ok(proxy) = open_accessible(&conn, &object_ref).await else {
continue;
};
let index = nodes.len() as u32;
Expand All @@ -161,8 +163,7 @@ pub async fn perform_action(
) -> Result<ActionInvocation> {
let conn = connect().await?;
let object_ref = object_ref_from_id(object_ref_id)?;
let proxy = conn
.object_as_accessible(&object_ref)
let proxy = open_accessible(&conn, &object_ref)
.await
.with_context(|| format!("failed to open AT-SPI object {object_ref_id}"))?;
let action = proxy
Expand Down Expand Up @@ -191,8 +192,7 @@ pub async fn perform_action(
pub async fn set_element_value(object_ref_id: &str, value: &str) -> Result<ValueSetInvocation> {
let conn = connect().await?;
let object_ref = object_ref_from_id(object_ref_id)?;
let proxy = conn
.object_as_accessible(&object_ref)
let proxy = open_accessible(&conn, &object_ref)
.await
.with_context(|| format!("failed to open AT-SPI object {object_ref_id}"))?;
let proxies = proxy.proxies().await?;
Expand Down Expand Up @@ -240,6 +240,25 @@ async fn connect() -> Result<AccessibilityConnection> {
.context("failed to connect to AT-SPI bus")
}

/// Open an `AccessibleProxy` for an object on the a11y bus.
///
/// We deliberately avoid `AccessibilityConnection::object_as_accessible` (the
/// `P2P` trait). For apps that advertise a peer-to-peer bus address it routes
/// reads over that socket, but for apps that don't (notably GTK4 apps such as
/// Nautilus / Text Editor / baobab, which don't implement the legacy
/// `GetApplicationBusAddress`) it falls back to a proxy built with only a path
/// and *no destination*. On the shared a11y bus that proxy can't address the
/// app and every call fails with `ServiceUnknown`, which surfaces as an empty
/// tree (`role: "unknown"`, `child_count: 0`). `as_accessible_proxy` always
/// pins the destination to the object's bus name, so it works for every app
/// regardless of P2P support. See issue #31.
async fn open_accessible<'r>(
conn: &AccessibilityConnection,
object_ref: &'r ObjectRefOwned,
) -> Result<AccessibleProxy<'r>, atspi::AtspiError> {
object_ref.as_accessible_proxy(conn.connection()).await
}
Comment on lines +255 to +260

@gemini-code-assist gemini-code-assist Bot Jun 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The lifetime of the returned AccessibleProxy is conceptually tied to the zbus::Connection (borrowed from conn), not the ObjectRefOwned reference (object_ref).

By tying the returned proxy's lifetime to 'r (the lifetime of object_ref), you unnecessarily restrict the lifetime of the returned proxy to the scope of the temporary object_ref reference. Although this compiles in the current call sites due to covariance and localized usage, it is more idiomatic and robust to tie the returned proxy's lifetime to the connection 'conn.

Suggested change
async fn open_accessible<'r>(
conn: &AccessibilityConnection,
object_ref: &'r ObjectRefOwned,
) -> Result<AccessibleProxy<'r>, atspi::AtspiError> {
object_ref.as_accessible_proxy(conn.connection()).await
}
async fn open_accessible<'conn>(
conn: &'conn AccessibilityConnection,
object_ref: &ObjectRefOwned,
) -> Result<AccessibleProxy<'conn>, atspi::AtspiError> {
object_ref.as_accessible_proxy(conn.connection()).await
}


async fn registry_children(conn: &AccessibilityConnection) -> Result<Vec<ObjectRefOwned>> {
let root = conn
.root_accessible_on_registry()
Expand Down Expand Up @@ -313,7 +332,7 @@ async fn root_matches(
object_ref: &ObjectRefOwned,
needle: &str,
) -> bool {
let Ok(proxy) = conn.object_as_accessible(object_ref).await else {
let Ok(proxy) = open_accessible(conn, object_ref).await else {
return object_ref_id(object_ref)
.to_ascii_lowercase()
.contains(needle);
Expand All @@ -325,7 +344,7 @@ async fn root_matches(

let children = proxy.get_children().await.unwrap_or_default();
for child_ref in children.into_iter().take(8) {
let Ok(child_proxy) = conn.object_as_accessible(&child_ref).await else {
let Ok(child_proxy) = open_accessible(conn, &child_ref).await else {
continue;
};
if proxy_matches(&child_proxy, &child_ref, needle).await {
Expand Down
Loading