Skip to content

feat: add getVersion() method#851

Open
haosenwang1018 wants to merge 1 commit intoagentscope-ai:mainfrom
haosenwang1018:feat/add-get-version
Open

feat: add getVersion() method#851
haosenwang1018 wants to merge 1 commit intoagentscope-ai:mainfrom
haosenwang1018:feat/add-get-version

Conversation

@haosenwang1018
Copy link

Add getVersion() method to return version string.

@haosenwang1018 haosenwang1018 requested a review from a team March 2, 2026 11:59
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new public utility method to the Version class, enabling applications to easily access the current version of the AgentScope Java library. This enhancement provides a standardized and straightforward way to programmatically determine the library's version, which can be beneficial for various purposes such as logging, debugging, or ensuring compatibility.

Highlights

  • New Feature: A new static method, getVersion(), has been added to the Version class, allowing direct retrieval of the AgentScope Java version string.
Changelog
  • agentscope-core/src/main/java/io/agentscope/core/Version.java
    • Added a new public static method getVersion() that returns the VERSION string.
    • Included Javadoc comments for the newly added getVersion() method.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@cla-assistant
Copy link

cla-assistant bot commented Mar 2, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant
Copy link

cla-assistant bot commented Mar 2, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new getVersion() method. While the implementation is straightforward, it's missing a corresponding unit test. All new public methods should be covered by tests to ensure they work as expected and to guard against future regressions. Please add a test case for getVersion() in VersionTest.java. I've also left a comment regarding a potential design improvement for better encapsulation.

Comment on lines +53 to +55
public static String getVersion() {
return VERSION;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This method is redundant as it provides a getter for the VERSION constant, which is already public. Having two public access points for the same value can lead to inconsistent usage across the codebase. For better encapsulation, the VERSION constant should be made private, and this getter should be the sole public access point. Please consider addressing this in a follow-up change to improve the API design.

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...core/src/main/java/io/agentscope/core/Version.java 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant