Merged
Conversation
Collaborator
Author
|
Interesting... that failing test passes locally. |
Collaborator
|
macos diff has different error output, i'd just uhh pipe 2>/dev/null ig |
mira-alford
commented
Mar 25, 2026
Collaborator
Author
There was a problem hiding this comment.
Unfamiliar with cramtest, but something like this @katrinafyi ?
agle
reviewed
Mar 25, 2026
agle
approved these changes
Apr 1, 2026
Owner
agle
left a comment
agle
left a comment
There was a problem hiding this comment.
A doc comment or possibly a well-documented example in a cram test would be good to help understand the signature and expected behaviour of the generated memory encoding contracts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial memory encoding transform/spec experiment. Split encoding is working for basic memory safety (though lacks gammas for now). Some IL examples included for malloc/free.
More importantly for review this includes some fixes to the boogie generation for bugs that came up and the refactor to field read/writes to support custom sorts.