Skip to content

Feat: implement the processor server#4263

Draft
lacroixthomas wants to merge 1 commit intoagones-dev:mainfrom
lacroixthomas:features/implement-processor-server
Draft

Feat: implement the processor server#4263
lacroixthomas wants to merge 1 commit intoagones-dev:mainfrom
lacroixthomas:features/implement-processor-server

Conversation

@lacroixthomas
Copy link
Collaborator

@lacroixthomas lacroixthomas commented Sep 2, 2025

What type of PR is this?
/kind feature

What this PR does / Why we need it:

Implementation of the processor server behind dev feature flag

TODO (some might be on another MR):

  • New Metrics ? (Other PR)
  • TLS ? Is it needed ?
  • Unit tests

Which issue(s) this PR fixes:
Part of #4190

Special notes for your reviewer:
Opening the draft for early feedbacks

@github-actions github-actions bot added kind/feature New features for Agones size/XL labels Sep 2, 2025
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 0dfb8b31-e31f-4756-9245-fc6a5ef6c6fe

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas
Copy link
Collaborator Author

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: be7478b2-5c1c-498c-8498-6d3e35aaedb5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-3b0ba99

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 4, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 91746f34-8ce0-429a-b492-139ab1d0e898

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas
Copy link
Collaborator Author

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: e64c3f64-8657-4721-8904-83a4c840bd47

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-6dec885

@github-actions github-actions bot added the size/L label Sep 7, 2025
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 1241bbbd-7bde-46ec-95ec-3b8712be910f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-6351400

@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from 6351400 to c239fdb Compare October 22, 2025 21:02
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 97a4c8b6-9fdc-444b-8694-653b14e80797

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 04dff753-1c63-4882-bb56-0f2ec1158e07

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 4aa098c0-e599-4386-8bd8-7f51ecf4034f

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from 56cf40e to de22bdc Compare November 19, 2025 22:36
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 0e0967ca-55e6-4012-9f36-c8c00cf9108c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas
Copy link
Collaborator Author

I'll come back to this task in the next days / week, didn't forget about it !

@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from de22bdc to 3078f81 Compare December 3, 2025 23:31
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: af923d1a-67cc-48c6-9039-634cda0feb28

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from 3078f81 to ddd9a28 Compare December 17, 2025 23:05
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 1c732008-568e-45a8-9455-40c393278ecd

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 792e8178-8cf5-4479-b4f8-1f6dbd845439

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from 87c55c4 to 2518c80 Compare December 20, 2025 20:48
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: c9e51116-e6b7-454a-8717-4a8a60a7d4f8

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 4a67f459-b5ca-4c84-86a9-a845fa4f6d7a

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 00fa2651-2759-4492-ae4c-3aba4a8c5149

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 83f67120-4d5a-4dd8-8c97-e480915659b9

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas
Copy link
Collaborator Author

/gcbrun

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: d95ced1a-74a5-4653-90b8-27ce24cade64

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 88325745-3cfa-4a8e-9f16-d10ca7249f57

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-ebc767c

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 695df557-35d1-4989-a6c2-ed22ad0ae489

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-2ac6bcd

@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from 2ac6bcd to 2c56805 Compare December 29, 2025 01:13
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: ae481ca3-0326-495d-96ef-c576b0b897b1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-2c56805

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 251769c1-44a6-4da2-8412-8fb482ce4b35

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-157d44b

@lacroixthomas
Copy link
Collaborator Author

I'm waiting for the e2e to finish and I'll rollback the feature gate from alpha to dev, it's just to confirm that the e2e still works with the new processor (which seems to be alright now !)

It's still in draft because I want to write some unit tests around the handler.go from the processor server, only added you as reviewers, if you want to have a look before the unit tests are done 😄

I'm gonna create an other PR to add new metrics

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 27499b51-b73c-4d32-88b4-125e998dc67b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: a47da26c-d7ac-49b4-b2b6-9d931adfffd7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.56.0-dev-19ec0a4

@lacroixthomas
Copy link
Collaborator Author

Note: Ensure that this issue is also part of this new design: #4415
About a request context cancelled, to not add it to the list to process or ensuring it wont be processed - more info on the issue

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: b641d47d-5fda-403b-b3be-7a82fb901854

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from 4bdd4f1 to feb3f1c Compare February 19, 2026 22:35
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: e7d9ff2f-0cbd-4ec5-bec7-75f03266ecc3

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 79a156da-4315-44a2-a3c0-f9930525910c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

feat: add metrics setup for processor

feat: remove exit from sigterm and let it shutdown gracefully

feat: fix conflicts

feat: update logs

feat: test pipeline with ProcessorAllocator in alpha

feat: test pipeline with ProcessorAllocator in alpha

feat: debug e2e failing

feat: debug e2e failing

feat: fix error handling and feature gate from dep env

feat: fix extension and allocator with processor server

feat: update unit test

feat: add missing status

feat: fix missing namespace

feat: refactor a bit the error handling

feat: update copyright to 2026

feat: minor changes

feat: rollback unit test fix (other PR)

feat: fix rebase issue

feat: fix unit test from rebase
@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from 1165f8b to 6ec6aa6 Compare February 19, 2026 23:10
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: a6f0bf7f-0b5d-4344-b56e-d7c68035495b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.56.0-dev-6ec6aa6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature New features for Agones size/L size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants