Skip to content

Retire tkinter chat popup; route chat hotkeys/tray to the web Chat tab #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agr77one merged 1 commit into from
Jun 16, 2026
Merged

Retire tkinter chat popup; route chat hotkeys/tray to the web Chat tab #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions installer/fastflowprompt.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ Build:

Output: dist/FastFlowPrompt/ (onedir, ~25 MB after merge dedupe)

Produces four executables sharing one runtime tree:
Produces three executables sharing one runtime tree (chat is now served by the
daemon's web dashboard — the standalone chat popup was retired):

dist/FastFlowPrompt/
├── ffp-daemon.exe windowed, long-running action server
├── ffp-daemon.exe windowed, long-running action server (+ web chat)
├── ffp-grammar-fix.exe console, AHK subprocess fallback
├── ffp-chat.exe windowed, chat popup
├── ffp-first-run.exe windowed, first-run wizard
├── _internal/ shared Python runtime + dlls + py-modules
└── setup/defaults/ seed config (read-only)
Expand Down Expand Up @@ -66,7 +66,6 @@ HIDDEN_IMPORTS = [
"loopback_http",
"paths",
"grammar_fix",
"chat_popup",
"ffp_daemon",
"first_run",
"install",
Expand All @@ -83,9 +82,9 @@ DATAS = [
(os.path.join(SCRIPTS_DIR, "assets"), "assets"),
]

# NOTE: do NOT exclude tkinter — chat_popup.py and first_run.py import it, and
# excluding it ships ffp-chat.exe / ffp-first-run.exe without _tkinter, so they
# crash at launch. (Regression caught building the installer from this spec.)
# NOTE: do NOT exclude tkinter — first_run.py (the wizard) imports it; excluding
# it ships ffp-first-run.exe without _tkinter, so it crashes at launch.
# (Regression caught building the installer from this spec.)
EXCLUDES = [
"test", "unittest", "pydoc", "doctest",
"lib2to3", "pip", "setuptools", "wheel",
Expand All @@ -112,20 +111,17 @@ def _analysis(script_name: str) -> "Analysis":

a_daemon = _analysis("ffp_daemon.py")
a_grammar = _analysis("grammar_fix.py")
a_chat = _analysis("chat_popup.py")
a_wizard = _analysis("first_run.py")

# Dedupe shared deps across all four bundles.
# Dedupe shared deps across all three bundles.
MERGE(
(a_daemon, "ffp_daemon", "ffp-daemon"),
(a_grammar, "grammar_fix", "ffp-grammar-fix"),
(a_chat, "chat_popup", "ffp-chat"),
(a_wizard, "first_run", "ffp-first-run"),
)

pyz_daemon = PYZ(a_daemon.pure, a_daemon.zipped_data, cipher=block_cipher)
pyz_grammar = PYZ(a_grammar.pure, a_grammar.zipped_data, cipher=block_cipher)
pyz_chat = PYZ(a_chat.pure, a_chat.zipped_data, cipher=block_cipher)
pyz_wizard = PYZ(a_wizard.pure, a_wizard.zipped_data, cipher=block_cipher)


Expand Down Expand Up @@ -153,13 +149,11 @@ def _exe(pyz, analysis, name, console):

exe_daemon = _exe(pyz_daemon, a_daemon, "ffp-daemon", console=False)
exe_grammar = _exe(pyz_grammar, a_grammar, "ffp-grammar-fix", console=True)
exe_chat = _exe(pyz_chat, a_chat, "ffp-chat", console=False)
exe_wizard = _exe(pyz_wizard, a_wizard, "ffp-first-run", console=False)

COLLECT(
exe_daemon, a_daemon.binaries, a_daemon.zipfiles, a_daemon.datas,
exe_grammar, a_grammar.binaries, a_grammar.zipfiles, a_grammar.datas,
exe_chat, a_chat.binaries, a_chat.zipfiles, a_chat.datas,
exe_wizard, a_wizard.binaries, a_wizard.zipfiles, a_wizard.datas,
strip=False,
upx=False,
Expand Down
3 changes: 0 additions & 3 deletions installer/installer.iss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
; {app}\ Program Files\FastFlowPrompt (read-only)
; ffp-daemon.exe PyInstaller bundle, flattened into {app}
; ffp-grammar-fix.exe
; ffp-chat.exe
; ffp-first-run.exe
; _internal\ shared Python runtime + bundled datas
; ahk\
Expand Down Expand Up @@ -174,8 +173,6 @@ Root: HKLM; Subkey: "Software\Microsoft\Windows\CurrentVersion\Run"; \
; won't always trip the close-apps prompt. Kill explicitly.
Filename: "{sys}\taskkill.exe"; Parameters: "/F /IM ffp-daemon.exe /T"; \
RunOnceId: "KillDaemon"; Flags: runhidden waituntilterminated
Comment on lines 174 to 175

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep cleaning up the retired chat process

When uninstalling or upgrading from a build that could still have ffp-chat.exe running, this cleanup now only stops the daemon and AHK, while the new bundle also no longer installs a fresh ffp-chat.exe. An old popup/direct-launched process can therefore keep the obsolete executable locked or leave it behind in {app}; keep the ffp-chat.exe taskkill here for at least the transition, and/or add explicit install/uninstall deletion for the retired binary.

Useful? React with 👍 / 👎.

Filename: "{sys}\taskkill.exe"; Parameters: "/F /IM ffp-chat.exe /T"; \
RunOnceId: "KillChat"; Flags: runhidden waituntilterminated
Filename: "{sys}\taskkill.exe"; \
Parameters: "/F /IM AutoHotkey64.exe /FI ""WINDOWTITLE eq grammarFix*"""; \
RunOnceId: "KillAhk"; Flags: runhidden waituntilterminated
Expand Down
2 changes: 0 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ Issues = "https://github.com/agr77one/Fastflow/issues"
[project.scripts]
ffp-daemon = "ffp_daemon:main"
ffp-grammar-fix = "grammar_fix:main"
ffp-chat = "chat_popup:main"
ffp-first-run = "first_run:main"
ffp-install = "install:main"

Expand Down Expand Up @@ -93,7 +92,6 @@ py-modules = [
"loopback_http",
"paths",
"grammar_fix",
"chat_popup",
"ffp_daemon",
"first_run",
"install",
Expand Down
Loading