UX: in-page confirm (no native dialogs); tray shows real hotkey; ^+t->^!c#24
Conversation
…; ^+t→^!c Two user-reported issues: - NEVER use native JS confirm()/alert(): added an in-page confirmDialog() modal (createElement/textContent, Esc/Enter/backdrop-dismiss) and routed all six destructive/confirming actions through it — chat-thread delete, note delete, custom-mode delete, model remove, oversized-model pull, benchmark start. - Tray "Open Chat" hardcoded "Ctrl+Shift+T" even after rebinding; now shows HumanHotkey(currentHotkeys["open_chat"]) and re-renders on hotkey reload. - Changed the default open_chat hotkey ^+t → ^!c (Ctrl+Alt+C); ^+t collides with the browser "reopen closed tab" and other apps. Updated both config examples. node --check + AHK parse-check clean.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79d9986371
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| currentHotkeys := Map( | ||
| "grammar_fix", "^+g", | ||
| "open_chat", "^+t", | ||
| "open_chat", "^!c", |
There was a problem hiding this comment.
This changes the AHK runtime default to ^!c, but the dashboard/config snapshot still falls back to ^+t in scripts/grammar_fix.py:823-826, and the first-run wizard's HOTKEY_FIELDS still uses ^+t in scripts/first_run.py:61-64. For users whose config has no hotkeys block (the default config/seed path omits one), opening Config or finishing the wizard can persist ^+t as open_chat; on the next hotkey reload/restart, AHK treats that as an override and rebinds Open Chat back to Ctrl+Shift+T, undoing this change and making the tray show the old shortcut again.
Useful? React with 👍 / 👎.
2 participants
User-reported: (1) the dashboard used the browser's native
confirm()for deletes — replaced with an in-pageconfirmDialog()modal across all six confirm sites; (2) the tray "Open Chat" label was hardcodedCtrl+Shift+Twhile the real binding wasCtrl+Shift+1— now showsHumanHotkey(currentHotkeys["open_chat"]); (3) the defaultopen_chathotkey^+tcollides with the browser reopen-tab shortcut — changed to^!c(Ctrl+Alt+C). node --check + AHK parse-check clean.