Skip to content

more descriptive info log for "unhandled data"#7

Open
mvcoile wants to merge 1 commit into
ahihi:mainfrom
mvcoile:descriptive-unhandled-data
Open

more descriptive info log for "unhandled data"#7
mvcoile wants to merge 1 commit into
ahihi:mainfrom
mvcoile:descriptive-unhandled-data

Conversation

@mvcoile
Copy link
Copy Markdown
Contributor

@mvcoile mvcoile commented Oct 10, 2025

More descriptive info (changed from warn) log for received input in decimal format.

When trying to figure out why my touch button was returning "unhandled data 52", it took me a while to realise autocrap was talking to me in hex rather than the actual controller number that I needed for the config file.

  • Lowered from warn to info, as this is a useful to the user. Especially while working on the config file.
  • Just like the config file logging, use the same decimal format.

more descriptive (warn ->) info log for received input in decimal format
@ahihi
Copy link
Copy Markdown
Owner

ahihi commented Oct 10, 2025

i think showing the data in decimal is an improvement. but,

  1. the data coming in here is Automap data rather than MIDI, so mentioning midi in the message is inaccurate and potentially confusing for OSC users. although the Automap controller numbers and MIDI CCs are the same in the default config, this does not have to be the case.
  2. i am not sure i understand the rationale for changing from warn to info. warn messages are included when running with the info log level (default), and a warning seems to me the most semantically correct for indicating a failure to handle incoming data from the controller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants