Issue1220: Translator distribution as package (restructuring the repository)#291
Draft
roeger wants to merge 7 commits into
Draft
Issue1220: Translator distribution as package (restructuring the repository)#291roeger wants to merge 7 commits into
roeger wants to merge 7 commits into
Conversation
roeger
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative variant of distributing a translator package.
Advantage: same usage of the translator internally and via the distribution (as downward.translate).
Disadvantage: renames directory
srctodownward, which will cause some additional integration effort for all the forks.I still did not include the pyproject.toml and other packaging files in the root folder but the packaging for the distribution via pypi is done by a separate script misc/releases/prepare-translator-package.sh
(The content of pyproject.toml is not a proposal of the final entries.)
The translator (and submodules) can be called from the root folder via
python3 -m downward.translate(or for examplepython3 -m downward.translate.instantiate).