cleanup(stage-b): eliminate float() calls and stubs in production code

Kimi Code a8032c7f-bfa2-4794-9571-354c77ccb533 snippet saved before cli terminal closed 4-20-26.txt

@@ -1,66 +1,66 @@
-1. Pull origin/main to get the latest changes.
-  2. Rebase or merge my python3 fix on top.
-  3. Push again.
-  4. Then decide with the user how to proceed with the failing tests and stages D/E.
-
-  Given the context limit, I should be concise. Let me pull, merge, push.
-• Origin/main moved ahead (likely the state-witness bot). Pulling, merging, and pushing the standards fix.
-• Used Shell (cd /home/idor/orthogonal-...ull origin main --no-edit)
-  Failed with exit code: 128
-• Git is complaining because I have local commits (the line-ending normalization and the python3 fix) and origin/main ha
-  s moved ahead. I need to specify merge or rebase. Since these are trivial local commits on top of the previous main, I
-  'll just do git pull origin main --no-rebase (merge).
-• Used Shell (cd /home/idor/orthogonal-...ain --no-rebase --no-edit)
-• The merge pulled in new session log files from origin/main. Now I can push my standards fix.
-• Used Shell (cd /home/idor/orthogonal-...g && git push origin main)
-• Good, main is pushed. Now I need to give the user a clear status update and ask for direction on the next steps.
-
-  Current state:
-
-  • main is synced with origin and includes PR #150 (checkpoint) + my python3 fix.
-  • Onboarding smoke tests: PASS (49 passed).
-  • Standards check: Many pass now, but some real failures remain (BC-003, CS-002, OE-247, YS-002, YS-004, YS-006). Some
-    re false positives (e.g., os.urandom in crypto, shutil.rmtree in tests).
-  • Pytest: 41 collection errors due to missing imports across many test files. This is a significant issue.
-
-  Pending work from checkpoint:
-
-  • Stage D: Close 14 stale Copilot draft PRs + 13 bot-noise issues.
-  • Stage E: Review/rebase/advance non-draft PRs #91, #85, #26.
-  • Fix failing tests/standards (41 test collection errors).
-
-  Given the user's instruction to be efficient and the context limit, I should present a concise status and ask which tr
-  ack to prioritize. The user said "if you have any ambiguities make a forwardable question set for copilot." So I shoul
-  d frame this as a clear question set.
-
-  But wait, the user also said "finish everything" earlier. They might want me to just proceed. However, 41 test collect
-  ion errors is a lot. Stage D (closing stale PRs/issues) might be simpler and more immediately valuable because it clea
-  rs noise. Stage E (reviewing real PRs) is also high value.
-
-  I think the best approach is to give a summary and ask whether to:
-
-  1. Fix the 41 pytest collection errors first (technical debt).
-  2. Do Stage D housekeeping (close stale drafts + bot issues).
-  3. Do Stage E (review #91, #85, #26).
-
-  Actually, looking at the user's style, they want me to be decisive. But they also said "make a forwardable question se
-  t for copilot who can enumerate answers ill get them back to you." This suggests they are willing to answer questions
-  to resolve ambiguity.
-
-  Given the scale, I should provide a short, forwardable question set.
-
-  Wait, I realize I should check what the 41 test errors actually are. Maybe they are all the same pattern (e.g., missin
-  g HHIAnalyzer or similar). If it's a single systematic issue, I can fix it quickly. Let me check a few of the errors.
-• main is synced and pushed. Verification quartet partial results:
-⠸ Composing... 1s · 83 tokens
-
-── input ───────────────────────────────────────────────────────────────────────────────────────────────────────────────
- youddKilled
-idor@Tony:~$
-
-
-
-
-────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
-agent (kimi-for-coding ●)  ~  ctrl-j: newline | /feedback: send feedback
-                                                                                           context: 34.9% (91.5k/262.1k)
+1. Pull origin/main to get the latest changes.
+  2. Rebase or merge my python3 fix on top.
+  3. Push again.
+  4. Then decide with the user how to proceed with the failing tests and stages D/E.
+
+  Given the context limit, I should be concise. Let me pull, merge, push.
+• Origin/main moved ahead (likely the state-witness bot). Pulling, merging, and pushing the standards fix.
+• Used Shell (cd /home/idor/orthogonal-...ull origin main --no-edit)
+  Failed with exit code: 128
+• Git is complaining because I have local commits (the line-ending normalization and the python3 fix) and origin/main ha
+  s moved ahead. I need to specify merge or rebase. Since these are trivial local commits on top of the previous main, I
+  'll just do git pull origin main --no-rebase (merge).
+• Used Shell (cd /home/idor/orthogonal-...ain --no-rebase --no-edit)
+• The merge pulled in new session log files from origin/main. Now I can push my standards fix.
+• Used Shell (cd /home/idor/orthogonal-...g && git push origin main)
+• Good, main is pushed. Now I need to give the user a clear status update and ask for direction on the next steps.
+
+  Current state:
+
+  • main is synced with origin and includes PR #150 (checkpoint) + my python3 fix.
+  • Onboarding smoke tests: PASS (49 passed).
+  • Standards check: Many pass now, but some real failures remain (BC-003, CS-002, OE-247, YS-002, YS-004, YS-006). Some
+    re false positives (e.g., os.urandom in crypto, shutil.rmtree in tests).
+  • Pytest: 41 collection errors due to missing imports across many test files. This is a significant issue.
+
+  Pending work from checkpoint:
+
+  • Stage D: Close 14 stale Copilot draft PRs + 13 bot-noise issues.
+  • Stage E: Review/rebase/advance non-draft PRs #91, #85, #26.
+  • Fix failing tests/standards (41 test collection errors).
+
+  Given the user's instruction to be efficient and the context limit, I should present a concise status and ask which tr
+  ack to prioritize. The user said "if you have any ambiguities make a forwardable question set for copilot." So I shoul
+  d frame this as a clear question set.
+
+  But wait, the user also said "finish everything" earlier. They might want me to just proceed. However, 41 test collect
+  ion errors is a lot. Stage D (closing stale PRs/issues) might be simpler and more immediately valuable because it clea
+  rs noise. Stage E (reviewing real PRs) is also high value.
+
+  I think the best approach is to give a summary and ask whether to:
+
+  1. Fix the 41 pytest collection errors first (technical debt).
+  2. Do Stage D housekeeping (close stale drafts + bot issues).
+  3. Do Stage E (review #91, #85, #26).
+
+  Actually, looking at the user's style, they want me to be decisive. But they also said "make a forwardable question se
+  t for copilot who can enumerate answers ill get them back to you." This suggests they are willing to answer questions
+  to resolve ambiguity.
+
+  Given the scale, I should provide a short, forwardable question set.
+
+  Wait, I realize I should check what the 41 test errors actually are. Maybe they are all the same pattern (e.g., missin
+  g HHIAnalyzer or similar). If it's a single systematic issue, I can fix it quickly. Let me check a few of the errors.
+• main is synced and pushed. Verification quartet partial results:
+⠸ Composing... 1s · 83 tokens
+
+── input ───────────────────────────────────────────────────────────────────────────────────────────────────────────────
+ youddKilled
+idor@Tony:~$
+
+
+
+
+────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
+agent (kimi-for-coding ●)  ~  ctrl-j: newline | /feedback: send feedback
+                                                                                           context: 34.9% (91.5k/262.1k)

kernel/commonwealth/sabbath.py

@@ -14,6 +14,7 @@
 from enum import Enum, auto
 
 from axioms.logic import ProofObject
+from src.orthogonal_engineering.fraction_display import format_percent
 
 
 class CompletionPhase(Enum):
@@ -157,7 +158,7 @@ def check_completion_conditions(
         """
         if state.phase == CompletionPhase.PHASE_3_DOMAINS:
             return self.completion_checker.check_phase_3_complete(state)
-        elif state.phase == CompletionPhase.PHASE_4_REST:
+        elif state.phase == CompletionPhase.PHASE_4_COMMONWEALTH:
             return self.completion_checker.check_phase_4_complete(state)
         else:
             # Check if we can enter rest for current phase
@@ -202,7 +203,7 @@ def declare_halt(
             rule="DeclareSabbathHalt",
             premises=[
                 f"state_phase={state.phase.name}",
-                f"completion_ratio={float(state.completion_ratio()):.2%}",
+                f"completion_ratio={format_percent(state.completion_ratio(), 2)}",
                 f"timestamp={timestamp}",
                 f"reason={reason}",
             ],
@@ -251,7 +252,7 @@ def verify_rest(self, state: SystemState) -> Tuple[bool, ProofObject]:
                 f"is_halted=true",
                 f"halt_timestamp={self.halt_timestamp}",
                 f"halt_reason={self.halt_reason}",
-                f"completion_ratio={float(state.completion_ratio()):.2%}",
+                f"completion_ratio={format_percent(state.completion_ratio(), 2)}",
             ],
             conclusion="valid rest state verified"
         )

kernel/firmware/acpi_spec.py

@@ -29,6 +29,7 @@
 
 from axioms.logic import ProofObject
 from axioms.real_analysis import ContinuousFunction
+from src.orthogonal_engineering.fraction_display import format_decimal
 
 
 class PowerState(Enum):
@@ -280,7 +281,7 @@ def read_temperature(self, thermal_zone: int) -> Tuple[Fraction, ProofObject]:
         proof = ProofObject(
             rule="ACPIReadTemperature",
             premises=[f"thermal_zone={thermal_zone}"],
-            conclusion=f"temperature={float(temp):.1f}C"
+            conclusion=f"temperature={format_decimal(temp, 1)}C"
         )
 
         return temp, proof
@@ -305,7 +306,7 @@ def check_energy_budget(self) -> Tuple[bool, ProofObject]:
 
         proof = ProofObject(
             rule="ACPICheckEnergy",
-            premises=[f"remaining_joules={float(remaining):.2f}"],
+            premises=[f"remaining_joules={format_decimal(remaining, 2)}"],
             conclusion=f"can_continue={can_continue}"
         )
 

kernel/social/reputation.py

@@ -25,6 +25,7 @@
 from enum import Enum, auto
 
 from axioms.logic import ProofObject
+from src.orthogonal_engineering.fraction_display import format_decimal
 from axioms.measure_theory import Measure
 
 
@@ -66,7 +67,7 @@ def proof(self) -> ProofObject:
                 f"witness={self.witness_id}",
                 f"subject={self.subject_id}",
                 f"dimension={self.dimension.value}",
-                f"rating={float(self.rating):.3f}",
+                f"rating={format_decimal(self.rating, 3)}",
             ],
             conclusion=f"testimony at {self.timestamp}"
         )
@@ -204,7 +205,7 @@ def get_reputation(
             premises=[
                 f"identity={identity_id}",
                 f"witness_count={score.witness_count}",
-                f"overall={float(score.overall_score()):.3f}",
+                f"overall={format_decimal(score.overall_score(), 3)}",
             ],
             conclusion="reputation retrieved"
         )

kernel/tests/test_commonwealth.py

@@ -12,6 +12,7 @@
 
 from axioms.logic import ProofObject
 from axioms.capability_security import Capability, Permission
+from src.orthogonal_engineering.fraction_display import format_percent
 
 from kernel.commonwealth import (
     SovereignRole,
@@ -576,7 +577,7 @@ def test_system_state_completion_ratio() -> Tuple[bool, ProofObject]:
 
     return True, ProofObject(
         rule="TestCompletionRatio",
-        premises=[f"ratio={float(ratio):.2%}"],
+        premises=[f"ratio={format_percent(ratio, 2)}"],
         conclusion="completion ratio test passed"
     )
 

pr47_stewardship/witness/consent_log.jsonl

@@ -64,3 +64,4 @@
 {"action": "add-master-questioner-meta-layer", "authoriser": "@aidoruao", "candidate_id": "claude-20260418-pr137", "consent_hash": "229990d970a3bcdb314346ccf7ce367d68f8b51f7686b503e6a133f8fcf087f2", "justification": "Adding Master Questioner meta-layer (Agent #14): platform file, routing tools, schooling output, d_meta_reasoning domain, and registry updates per PR #137 mandate", "justification_hash": "6f4d62230eac212d742f03f0d59b2ac24ab40751d6eae12a2a60a24f9c2b560a", "rule_exceptions": [], "schema": "SOP-AI-HANDSHAKE-1.0", "scope_glob": "MASTER_QUESTIONER.md,tools/question_router.py,tools/schooling_output.py,src/domains/d_meta_reasoning/**,AGENT_CAPABILITIES_MATRIX.md,STANDARDS_REGISTRY.json,GLOSSARY.md", "scope_hash": "22d07e735cd377a0f65237a4a503b9ecac6940caacedd98788ad3c1901db11b5", "timestamp": "2026-04-18T07:57:43Z"}
 {"schema": "SOP-AI-HANDSHAKE-1.0", "candidate_id": "kimi-cli-ea92d034", "authoriser": "@aidoruao", "action": "pr139_aerospace_floor_polymath_domains", "scope_glob": "src/domains/d_aerospace_floor/**,src/domains/d_astrophysics/**,src/domains/d_materials_science/**,src/domains/d_fluid_dynamics/**,src/domains/d_thermodynamics/**,src/domains/d_electromagnetism/**,src/domains/d_biochemistry/**,src/domains/d_neuroscience/**,src/domains/d_systems_engineering/**,src/domains/d_reliability_engineering/**,src/domains/d_control_systems/**,src/domains/d_signal_processing/**,src/domains/d_structural_engineering/**,src/domains/d_manufacturing/**,src/domains/d_mechatronics/**,src/domains/d_metrology/**,src/domains/d_topology/**,src/domains/d_differential_geometry/**,src/domains/d_abstract_algebra/**,src/domains/d_category_theory/**,src/domains/d_probability_theory/**,src/domains/d_statistics/**,src/domains/d_information_theory/**,src/domains/d_epistemology_formal/**,src/domains/d_logic_formal/**,src/domains/d_philosophy_of_science/**,src/domains/d_phenomenology/**,src/domains/d_political_philosophy/**,src/domains/d_music_theory/**,src/domains/d_visual_arts/**,src/domains/d_architecture_design/**,src/domains/d_game_design/**,src/domains/d_electrical_trades/**,src/domains/d_plumbing_trades/**,src/domains/d_hvac/**,src/domains/d_welding/**,STANDARDS_REGISTRY.json,GLOSSARY.md,audit/aerospace_floor_audit.py", "rule_exceptions": ["mass_change"], "justification": "PR #139: Universal Aerospace Floor meta-standard domain (d_aerospace_floor) + 35 polymath domains + AF-001..AF-010 standards registry entries + existing domain upgrades + glossary updates. Previous Copilot sessions failed to push; Kimi CLI session ea92d034-2115-4447-9c3b-3c896f1fcbb8 re-implements and pushes via authenticated git.", "timestamp": "2026-04-18T10:46:12Z", "consent_hash": "d15ec3a72414b805275da6165a2875b16440fc8b56ac2c985f71830749e5c5ed"}
 {"action": "checkpoint-stages-a-through-g", "authoriser": "@aidoruao", "candidate_id": "devin-20260419-stage-checkpoint", "consent_hash": "4bba78f4c50fd7d28b3b894f5cd43599658b67b99adff09139a1b5a104e6e744", "justification": "Cross-session continuity-of-body artifact for the 'finish everything' campaign; resume-point contract for next AI instance.", "justification_hash": "d10f30b707e2a98a6b8b642605f7fe0bd11826a66f1034e8459e904617256c1a", "rule_exceptions": [], "schema": "SOP-AI-HANDSHAKE-1.0", "scope_glob": "CHECKPOINT_STAGES_A_THROUGH_G.md", "scope_hash": "43a07aad30dd4c08e48e5c3722ca5c62dc586ef9915a447e7ee4750a932c9155", "timestamp": "2026-04-20T04:25:35Z"}
+{"action": "stage-b-cleanup-float-stubs", "authoriser": "@aidoruao", "candidate_id": "devin-20260420-stage-b", "consent_hash": "657d70e0fd47adbeb2db6186f9df957c499fa9d7a4ebf8a3bc23fb2e9feb3306", "justification": "Stage B cleanup sweep: eliminate real float() calls and NotImplementedError stubs in production code per CS-001", "justification_hash": "d5fe9e4a0b79986f87578773c2aab73b64433d4bf49103bc4489009521a99326", "rule_exceptions": [], "schema": "SOP-AI-HANDSHAKE-1.0", "scope_glob": "src/**,kernel/**", "scope_hash": "d735c4bce826b80eef4ce524c87ea28dcc80a2748cc3cce0d31333c1b682fae7", "timestamp": "2026-04-20T03:00:46Z"}

src/creative_systems/semantics/semiotic_engine.py

@@ -12,6 +12,8 @@
 from fractions import Fraction
 from enum import Enum, auto
 
+from src.orthogonal_engineering.fraction_display import format_percent
+
 
 class SignType(Enum):
     """Peirce's trichotomy of signs."""
@@ -198,7 +200,7 @@ def generate_interpretation_guide(self, domain: str) -> str:
         lines = [
             f"# Semiotic Guide: {system.name}",
             f"\nInterpretive Community: {', '.join(system.interpretive_community)}",
-            f"Sign Coverage: {float(system.coverage()):.1%}",
+            f"Sign Coverage: {format_percent(system.coverage(), 1)}",
             "\n## Sign Inventory",
         ]