Add Password Recovery #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
charansr
force-pushed
the
56-password-recovery
branch
from
76b7dc8 to
33db8cd
Compare
charansr
force-pushed
the
56-password-recovery
branch
from
1f51a9c to
ce7399d
Compare
Collaborator
Author
|
The build failed at ./app/api/auth/[...nextauth]/route.ts:23:13 but the code in that file is exactly the same as in main. Was the Github build check changed? |
Collaborator
|
@blickly, can you take a look at why the build is failing now? The error logs show a type error but not sure how it was introduced. |
(Still missing logging of nametag actions)
Shaomei
requested changes
Dec 5, 2024
Collaborator
There was a problem hiding this comment.
Thanks @charansr for working on this. The key requests in my review are:
- Componentize functionalities following the ethos of React;
- Reduce repeated css / ts code by create reusable classes;
- Add relevant tests (unit tests and/or e2e tests) for the new functionalities.
| }; | ||
|
|
||
| return ( | ||
| <Container maxWidth="sm"> |
| import axios from "axios"; | ||
| import { TextField, Button, Typography, Container } from "@mui/material"; | ||
|
|
||
| const ForgotPassword: React.FC = () => { |
Collaborator
There was a problem hiding this comment.
Wouldn't it be better to create a React component for this rather than a new page?
| import axios from "axios"; | ||
| import { useSearchParams } from "next/navigation"; | ||
|
|
||
| const ResetPassword: React.FC = () => { |
Collaborator
There was a problem hiding this comment.
Same comment here: wouldn't it be better to componentize this function rather than making it a new page?
Comment on lines
+50
to
+52
| <div className="flex items-center justify-center min-h-screen bg-white"> | ||
| <div className="max-w-md w-full p-6 bg-white rounded-lg"> | ||
| <h1 className="text-2xl font-semibold mb-6 text-center"> |
Collaborator
There was a problem hiding this comment.
A lot of redundant CSS here as in app/recover-password/page.tsx, please consolidate them into css classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.