Fix BodyPartReader.read() returning bytearray instead of bytes#12494
Closed
terminalchai wants to merge 1 commit intoaio-libs:masterfrom
Closed
Fix BodyPartReader.read() returning bytearray instead of bytes#12494terminalchai wants to merge 1 commit intoaio-libs:masterfrom
terminalchai wants to merge 1 commit intoaio-libs:masterfrom
Conversation
BodyPartReader.read() accumulated data into a bytearray internally
but returned it directly, violating the documented return type of
bytes. This caused downstream TypeError when trying to JSON-serialize
the result, e.g. json.dumps({'filename': data}).
The same defect existed on both code paths in read():
- decode=False: returned the raw accumulation bytearray
- decode=True: returned the decoded accumulation bytearray
Fix by wrapping both return values in bytes().
Fixes aio-libs#12404
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BodyPartReader.read()accumulates data into abytearrayinternally but returns it directly without converting tobytes, violating the documented return type.This affects both code paths in
read():decode=False: returns the rawbytearrayaccumulationdecode=True: returns the decodedbytearrayaccumulationThe result is a silent type error downstream. For example, trying to JSON-serialize the result fails:
Fixes #12404.
Fix
Wrap both return values in
bytes():One-line change on each code path. Two regression tests added to
tests/test_multipart.pycovering bothdecode=Falseanddecode=True.