Fix Health Connect "startTime must be before endTime" crash at day boundary

[Copilot]

Two independent time reads in todayRange() created a race where LocalDate.now() could tick to the next day while Instant.now() still held a timestamp from the previous millisecond, making startOfDay > now and causing every Health Connect query to fail.

• Single clock snapshot — derive startOfDay from one Instant.now() call instead of two separate time reads
• Unconditional end-bound clamp — use maxOf(now, startOfDay.plusSeconds(1)) to guarantee a strictly non-empty interval regardless of clock skew or DST transitions

private fun todayRange(): Pair<Instant, Instant> {
    val zone = ZoneId.systemDefault()
    val now = Instant.now()
    val startOfDay = now.atZone(zone).toLocalDate().atStartOfDay(zone).toInstant()
    val endTime = maxOf(now, startOfDay.plusSeconds(1))
    return startOfDay to endTime
}

[air17]

@copilot can you check if this fixes the error Error: startTime must be before endTime. And if something else is necessary to do

[Copilot]

@copilot can you check if this fixes the error Error: startTime must be before endTime. And if something else is necessary to do

Yes, the fix fully addresses the startTime must be before endTime error.

Root cause: The original todayRange() made two independent time reads — LocalDate.now() and Instant.now() — at slightly different clock ticks. At midnight exactly, LocalDate.now() could already return the new day (giving startOfDay = midnight) while Instant.now() still held a timestamp from the previous millisecond, so startOfDay > now → Health Connect rejected the query.

What the fix does (lines 166–172):

1. Single clock snapshot — Instant.now() is called once; startOfDay is derived from that same instant, eliminating the race.
2. Hard lower-bound clamp — maxOf(now, startOfDay.plusSeconds(1)) guarantees endTime > startOfDay even under DST transitions or any remaining clock skew.

Every TimeRangeFilter.between call in the whole codebase goes through this one todayRange() helper, so all five call sites are covered. Nothing else needs to change.

[Copilot]

Pull request overview

Fixes a Health Connect crash at the day boundary by ensuring todayRange() always returns a strictly non-empty time window derived from a single clock snapshot, preventing TimeRangeFilter.between(start, end) from receiving an invalid interval.

Changes:

• Compute startOfDay from a single Instant.now() snapshot (avoids the LocalDate.now() / Instant.now() race).
• Guarantee endTime > startOfDay via an end-bound clamp (maxOf(now, startOfDay.plusSeconds(1))).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.