Add ACRA email crash reporting with user-consent dialog#329
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 970ec91681
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| initAcra { | ||
| buildConfigClass = BuildConfig::class.java | ||
| reportFormat = StringFormat.KEY_VALUE_LIST |
There was a problem hiding this comment.
Limit ACRA's default report content
For production users who have enabled file logging, this leaves ACRA's default reportContent in place, which includes LOGCAT; in that mode LoggerInteractor plants Timber.DebugTree(), and AutofillStructureParser logs parsed ViewNode.text, so a crash shortly after an autofill flow can put usernames/password-field contents into the email body. Please set an explicit reportContent that excludes logcat (or otherwise redact/disable those logs) before enabling ACRA by default.
Useful? React with 👍 / 👎.
Motivation
Description
gradle/libs.versions.toml) and declared the dialog and mail modules inapp/build.gradle.kts.App.attachBaseContext(...)usinginitAcra {}with a report format ofKEY_VALUE_LIST, a consent dialog configuration, andmailSenderconfigured to send the report inline (reportAsFile = false).app/src/main/res/values/strings.xml) and the support email inuntranslatable-strings.xml.Testing
git diff --checkand static diff checks which reported no problems../gradlew app:spotlessApplywhich failed due to environment/network limitation (dependency download returned HTTP 403 forgoogle-java-format)../gradlew app:compileFdroidDebugKotlinand./gradlew testwhich were blocked by a missing Android SDK in the environment (error: SDK location not found).Codex Task