Add optional crash reporting#331
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cdf6ed4349
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| constructor.newInstance(this, loggerInteractor, settings) as DIModuleBuilder | ||
| val moduleBuilder = if (BuildConfig.DEBUG) { | ||
| DebugModuleBuilder(deps) |
There was a problem hiding this comment.
Because app/src/main is compiled for release variants too, and the only DebugModuleBuilder implementation is under app/src/debug, assembleFdroidRelease and assembleGplayRelease will fail to resolve this reference even though it is guarded by BuildConfig.DEBUG; the Kotlin compiler still resolves both branches. Keep the reflection/source-set split or move a release-safe factory into main.
Useful? React with 👍 / 👎.
| - name: Build apk's | ||
| run: | | ||
| ./gradlew app:assembleFdroidDebug app:assembleFdroidRelease app:assembleFdroidAutomation | ||
| app:assembleFdroidRelease app:assembleAutomationDebug |
There was a problem hiding this comment.
On tag builds this step now asks the shell to execute a command literally named app:assembleFdroidRelease, so the GitHub release job will stop with command not found before any APKs are produced or renamed. This should still invoke Gradle, e.g. through ./gradlew, as the pipeline workflow does for these tasks.
Useful? React with 👍 / 👎.
1 participant
No description provided.