Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[WS-303] Fix cmd2 version to >=2.5.11 and <3.0.0
Motivation and Context
aiverify-moonshot package on Pypi will resolve cmd2 to v3.10, which broke Interactive CLI feature.
Type of Change
How to Test
poetry lock,poetry export -f requirements.txtfor moonshot and moonshot-data, then compared requirements.txt to ensure cmd2 version is not >=3.0.0:pip install -r requirements.txtmoonshot first, then moonshot-data.pip install -r requirements.txtboth moonshot and moonshot-data at the same time.python -m buildto generate aiverify-moonshot wheel file,pip install the aiverify-moonshotwheel file, and thenpip install -r requirements.txtfor moonshot-data.Checklist
Please check all the boxes that apply to this pull request using "x":
Screenshots (if applicable)
[If the changes involve visual modifications, include screenshots or GIFs that demonstrate the changes.]
Additional Notes
[Add any additional information or context that might be relevant to reviewers.]
Developer Certificate of Origin