Skip to content

[WIP] Fix issue with event listener handling#2

Merged
ajaymauryabbn merged 1 commit into
mainfrom
copilot/fix-issue-3026
Jan 12, 2026
Merged

[WIP] Fix issue with event listener handling#2
ajaymauryabbn merged 1 commit into
mainfrom
copilot/fix-issue-3026

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 6, 2026

Plan: Replace ValueError/TypeError with InvalidArgumentError

  • Create custom exception class InvalidArgumentError in a new exceptions module
  • Replace ValueError in /home/runner/work/sql-eval/sql-eval/sql_eval/connectors/__init__.py (line 39)
  • Replace ValueError in /home/runner/work/sql-eval/sql-eval/sql_eval/datasets/__init__.py (lines 44, 62, 81)
  • Replace ValueError in /home/runner/work/sql-eval/sql-eval/sql_eval/core/evaluator.py (line 61)
  • Replace ValueError in /home/runner/work/sql-eval/sql-eval/sql_eval/llm_providers/__init__.py (line 41)
  • Update imports in all modified files
  • Export InvalidArgumentError from main package
  • Add tests for the custom exception
  • Run existing tests to ensure no breakage
  • Run linter to ensure code quality
Original prompt

chroma-core/chroma#3026. read this issue & , what fix need to be done here


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI requested a review from ajaymauryabbn January 6, 2026 11:03
Copilot stopped work on behalf of ajaymauryabbn due to an error January 6, 2026 11:03
@ajaymauryabbn ajaymauryabbn marked this pull request as ready for review January 12, 2026 05:28
@ajaymauryabbn ajaymauryabbn merged commit 88b84b1 into main Jan 12, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants