fix(component): isEquivalentTo nested result() returns {{bool}} (NEW-147)#55
Open
ximaks00-hue wants to merge 1 commit into
Open
Conversation
… (NEW-147)
ContainerAnalytics.isEquivalentTo wrapped the match expression in an inner result() call inside the outer result(). Lua callbacks therefore received {{bool}} instead of bool, breaking every inventory equivalence check on robots, drones, and transposers.
Original OpenComputers returned a plain boolean from the match; only the outer result() wrapper is required to marshal the Lua return value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContainerAnalytics.isEquivalentTowrapped the match expression in an innerresult()inside the outerresult(), so Lua received{{bool}}instead ofbool.`nRoot cause
Port regression in
ContainerAnalytics.scala— the innerresult()on the boolean match arm was copied incorrectly from a refactor; Original OpenComputers 1.12 returned a plain boolean from the match with only oneresult()wrapper.Fix
Remove the nested
result()call; return the boolean directly from the match expression.Test plan
isEquivalentTo(slot)returns a single boolean in LuatrueMade with Cursor