fix(agent): restore in-air block placement for drones (NEW-123)#56
Open
ximaks00-hue wants to merge 1 commit into
Open
fix(agent): restore in-air block placement for drones (NEW-123)#56ximaks00-hue wants to merge 1 commit into
ximaks00-hue wants to merge 1 commit into
Conversation
MC 1.12 rayTraceBlocks returned null on a clear line of sight; MC 1.20 clip() always returns a HitResult with Type.MISS instead. The angel-placement branch still matched Option(None), which is never produced, so drones could not place blocks in open air. Match HitResult.Type.MISS explicitly, preserving the existing replaceable-block guard and entity proximity check from Original.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent.place()in open air) was dead code after the 1.12→1.20 port.Root cause
Original
rayTraceBlocksreturnednullon a clear line of sight. MC 1.20clip()always returns aHitResultwithType.MISS. The in-air branch matchedOption(None), which is never produced.Fix
Match
HitResult.Type.MISSexplicitly whencanPlaceInAiris allowed, preserving replaceable-block and entity proximity guards from Original.Test plan
Made with Cursor