fix(recipe): Lua BIOS craft + tier-4 CPU/HDD hooks (NEW-178, NEW-180, NEW-181)#57
Open
ximaks00-hue wants to merge 1 commit into
Open
Conversation
…oks (NEW-178, NEW-180, NEW-181) Datapack luabios.json stores oc:eeprom as the string bios.lua. patchRecipe mutated getResultItem(null), a throwaway stack that never reaches the player, so crafted Lua BIOS EEPROMs kept a path string instead of bytecode and could not boot. Move script resolution into addNBTToResult when the crafted item is EEPROM, matching Original Items.initStorage behaviour. Extend cpus/hdds arrays with CPUTier4, APUTier3, and HDDTier4 so setDefaultArch and disk color preservation run for tier-4 components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bios.luainstead of bytecode — would not boot.Root cause
patchRecipemutatedgetResultItem(null), a throwaway stack never given to the player. Original pre-built Lua BIOS at item registration; CE datapack stores a path string resolved only at craft time viaaddNBTToResult.Fix
addNBTToResultwhen output is EEPROM.cpus/hddsarrays with tier-4 items.patchRecipeEEPROM logic.Test plan
Made with Cursor