fix(block): isFaceSturdy + cable noOcclusion (NEW-163..166, 183, 184)#60
Open
ximaks00-hue wants to merge 2 commits into
Open
fix(block): isFaceSturdy + cable noOcclusion (NEW-163..166, 183, 184)#60ximaks00-hue wants to merge 2 commits into
ximaks00-hue wants to merge 2 commits into
Conversation
…..166, NEW-183, NEW-184) Port 1.12 isSideSolid semantics to MC 1.20 isFaceSturdy: Screen/Rack display faces are non-solid, NetSplitter/Transposer/Cable never solid, Assembler only on UP/DOWN. Register cables with noOcclusion() so they no longer block skylight like Original non-opaque cables.
…usion (MC 1.20.1 API) isFaceSturdy is computed from BlockState cache in 1.20.1 and cannot be overridden on Block subclasses. Revert non-compiling overrides; retain noOcclusion registration for Cable (NEW-183) and Assembler matching Original isOpaqueCube=false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port 1.12
isSideSolidrules to 1.20isFaceSturdy: Screen/Rack display faces non-solid; NetSplitter/Transposer/Cable never solid; Assembler only UP/DOWN; cables registered withnoOcclusion().Test plan