fix: robot load position, XP on kill, hover step height, fire extinguish (BUG-038, NEW-131, NEW-132, NEW-139)#67
Open
ximaks00-hue wants to merge 7 commits into
Conversation
…ish (BUG-038, NEW-131, NEW-132, NEW-139) BUG-038: On Computer.loadForServer set proxy.robot world position like Original setPos(getPos). Machine init and kernel state relied on correct robot coordinates during reload. NEW-131: ItemStack.EMPTY != null in 1.20; gate kill XP on !getItem(0).isEmpty so bare-handed kills no longer award XP. NEW-132: Restore default player step height to 0.6f (MC 1.20 default) when hover boots removed; 0.5f was 1.12 default. NEW-139: Delegate extinguishFire to Level.extinguishFire(player,pos,side) like Original ExtendedWorld instead of checking fire only at agent feet.
ximaks00-hue
force-pushed
the
fix/bug-038-new-131-139-core-gameplay
branch
from
86d8348 to
7bbafe5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Computer.loadForServerviasetWorldPosition(getBlockPos)— Original calledproxy.robot.setPos(getPos). Without this, the internal robot block entity stays at (0,0,0) during machine initialization after chunk reload.ItemStack.EMPTY != nullin MC 1.20, so bare-handed kills incorrectly awarded XP. Use!getItem(0).isEmpty.0.6fwhen hover boots removed (MC 1.20 default); CE used0.5ffrom 1.12.extinguishFiretoLevel.extinguishFire(player, pos, side)like OriginalExtendedWorld; CE only checked fire at agent feet.Test plan
extinguish()on adjacent fire block — fire removed like Original