fix: robot render bounds, GUI dispose, screen tier-3 precise, nanomachines overlay, template damage (NEW-152,153,179,173,188)#68
Open
ximaks00-hue wants to merge 2 commits into
Conversation
…hines overlay, template damage (NEW-152,153,179,173,188) NEW-152: Override getRenderBoundingBox with inflated collision AABB like Original for correct client culling/frustum. NEW-153: Close robot GUI via robotGui.robot == this accessor matching Original identity check. NEW-179: setPrecise gated on Tier.Three (8-bit depth) not Tier.Four; tier-3 screens support sub-pixel rendering. NEW-173: Render nanomachine HUD on HOTBAR overlay not DEBUG_TEXT (F3-only); matches Original ElementType.TEXT visibility. NEW-188: Template blacklist compares damage for damageable items like Original ItemStack.areItemsEqual.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getRenderBoundingBoxwith inflated collision AABB — Original grew collision box by 0.5; CE used default 1×1×1 causing premature client culling.robotGui.robot == thisaccessor matching Original identity check instead of inventory reference equality.setPrecisegated onTier.Three(8-bit depth screens), notTier.Four— tier-3 screens support sub-pixel rendering in Original.VanillaGuiOverlay.HOTBARinstead ofDEBUG_TEXT(F3-only) — matches OriginalElementType.TEXTalways-visible overlay.ItemStack.areItemsEqual.Test plan
setPrecise(true)— sub-pixel text enabled