fix: minecraft block drivers spawner, beacon, jukebox, note block, death messages (BUG-092-095, BUG-097)#70
Open
ximaks00-hue wants to merge 1 commit into
Conversation
…ath messages (BUG-092-095, BUG-097) BUG-092: SpawnerBlockEntity.getSpawner().save() instead of invalid BaseSpawner cast on tile entity. BUG-093: Null-check MobEffect before ForgeRegistries lookup to avoid NPE on empty beacon effects. BUG-094: Jukebox stop uses level event 1011 (SOUND_STOP_JUKEBOX_SONG) not 1010 play with id 0. BUG-095: Always fire note block event; return canTrigger as informational like Original triggerNote. BUG-097: Guard .player death message variant with Language.has() matching Original I18n.hasKey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SpawnerBlockEntity.getSpawner().save(tag)— CE cast tile entity toBaseSpawnercausingClassCastExceptionongetSpawningMobName().MobEffectbeforeForgeRegistries.getKey— NPE when beacon has no effect configured.stop()uses level event 1011 (SOUND_STOP_JUKEBOX_SONG); CE sent 1010 with id 0 which does not stop playback.canTrigger(air above) as informational — Original calledtriggerNoteunconditionally..playerdeath message variant withLanguage.getInstance.has()— matches OriginalI18n.hasKeyto avoid raw translation keys.Test plan
mob_spawner.getSpawningMobName()on spawner — no crash, correct entity idgetSecondaryEffect()returns nil not NPEstop()while playing — music stops