Add an option to shrink the PDF file where it is#23
Open
arwarw wants to merge 2 commits intoaklomp:masterfrom
Open
Add an option to shrink the PDF file where it is#23arwarw wants to merge 2 commits intoaklomp:masterfrom
arwarw wants to merge 2 commits intoaklomp:masterfrom
Conversation
Add an option -i to replace the input file with the shrunk output (if smaller). This creates a temporary directory in a secure and portable manner, cleaning it up afterwards. The temporary directory is created using 'mktemp' if present, otherwise the less secure method of including the PID, current time and possibly (if available) $RANDOM is used. The directory is removed upon exit, but carefully: 'rm -fr' is only executed on a then-empty directory after output.pdf has been removed. This could leak directories, but I consider that less of a problem than possibly removing something important.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes use of a temporary directory that is securely (as far as possible) created and cleaned up.