Added pbValue to allow changing the value without clicking the button#12
Open
elis wants to merge 4 commits intoakveo:masterfrom
Open
Added pbValue to allow changing the value without clicking the button#12elis wants to merge 4 commits intoakveo:masterfrom
elis wants to merge 4 commits intoakveo:masterfrom
Conversation
Member
|
Hey Eli, Thanks a lot for your PR! we have taken a look at your suggestion and agree that it can be useful. But unfortunately we think that there's a better way to do it: instead using value property 'pbValue': '@' we suggest to expose some 'control object', which will have functions to affect button behavior (like start/stop/change progress) 'pbControl': '='This object could be set inside of button's link function like this: $scope.pbControl = {
start: function() { .... },
setProgress: function() { ... },
stop: .....
}And can be used in this way: <button progress-button="" pb-control="someProperyInControllerScope"></button>Would be great if you provide another PR with these fixes. Otherwise, we can do it in a week or something. Thanks again for you help, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added
pbValueto the scope of the button to allow instantiating the progress without actually clicking the button.Also you'll see a change to
grunt-contrib-sass- feel free to ignore, it's just because I couldn't installgrunt-sassand needed it to compile.