Allow a node with a Run() method to run without a subcommand#614
Merged
alecthomas merged 1 commit intoJul 5, 2026
Merged
Conversation
A node that declares subcommands but also defines a Run() method can now be invoked on its own. checkMissingChildren no longer requires one of the subcommands to be selected when the node is runnable, and ctx.Run() already runs such a node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #561
A node that declares subcommands but also defines a
Run()method cannot currently be invoked on its own. Running the app with no subcommand fails withexpected one of ..., even thoughRun()is defined.This matches the approach suggested in the issue: if a node has a
Run()method it can act as a terminating command.checkMissingChildrenno longer requires one of the subcommands to be selected when the node is runnable.ctx.Run()already runs such a node (the application node with aRun()method), so no change was needed there.Subcommands still work, and nodes without a
Run()method still require a subcommand. Added tests for all three cases.