Refactor pool lifecycle: ctx-based termination and GracefulShutdown#1
Merged
Conversation
Pool initialization now accepts a ctx for immediate termination: workers exit without draining buffered tasks, though any in-flight task runs to completion. The existing Shutdown method is renamed to GracefulShutdown, which drains all buffered tasks and waits for workers to finish. It returns an error if the ctx was cancelled before shutdown completed.
Also use sync test to avoid waiting
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduce a pool context which can be used to terminate the pool without waiting for queued tasks to complete (ungraceful path), in addition to the existing Shutdown method now renamed to
GracefulShutdownwhich drains the tasks in the buffer.Also, replace
time.Sleepbysynctestand improve test coverage and readability.