Preserve existing pod annotations/labels to fix restarting Temporal deployments#986
Open
bmorton wants to merge 3 commits into
Open
Preserve existing pod annotations/labels to fix restarting Temporal deployments#986bmorton wants to merge 3 commits into
bmorton wants to merge 3 commits into
Conversation
bmorton
changed the title
Contributor
Author
|
I see there are some linting and testing issues that I need to resolve, but not quite sure how yet. It looks like the linter is still on v1, which doesn't support the version of Go that we're building with here. I'm trying to understand how to fix this without taking on 300+ lint fixes in the same PR |
|
Contributor
Author
|
There's some deeper stuff that needs to get fixed, but I was able to get the test passing and the lint fix applied without pulling on the Go version quite yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #858 where a
rollout restartwould cause in the new pod being terminated and the old pod continuing to persist. Now, we merge in the annotations/labels that are added by Kubernetes forrollout restartsuch that it can complete the rollout.I think this will end up being related to #746, but I don't have additional details there yet.
As a caveat, this was written with Copilot and Opus 4.6 under my supervision in VSCode, but I tested this in my homelab cluster already.