Skip to content

Add visual feedback when link is tapped #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bgeerdes wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add visual feedback when link is tapped #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6674896
Add visual feedback when link is tapped
bgeerdes May 23, 2025
57af648
Remove (recently) unnecessary import
bgeerdes May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 23 additions & 12 deletions lib/src/internals.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
* limitations under the License.
*/

import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:xml/xml_events.dart';

Expand Down Expand Up @@ -114,16 +113,25 @@ class Parser {

if (isLink) {
return TextSpan(
style: textStyle,
text: text,
recognizer: TapGestureRecognizer()
..onTap = () {
if (linksCallback != null) {
linksCallback!(link);
} else {
debugPrint('Add a link callback to visit ${link.toString()}');
}
},
children: [
WidgetSpan(
alignment: PlaceholderAlignment.baseline,
baseline: TextBaseline.alphabetic,
child: Material(
type: MaterialType.transparency,
child: InkWell(
onTap: () {
if (linksCallback != null) {
linksCallback!(link);
} else {
debugPrint('Add a link callback to visit ${link.toString()}');
}
},
child: Text(text, style: textStyle),
),
),
),
],
);
}
return TextSpan(style: textStyle, text: text);
Expand Down Expand Up @@ -329,7 +337,10 @@ class Parser {

if (event is XmlTextEvent) {
final TextSpan currentSpan = _handleText(event.value);
if (currentSpan.text?.isNotEmpty == true) {
if (
currentSpan.text?.isNotEmpty == true ||
currentSpan.children?.isNotEmpty == true
) {
spans.add(currentSpan);
}
}
Expand Down