chore: add return type hints to utility functions in functionals.py (Phase 2)#389
Open
guozhihao-224 wants to merge 1 commit intoalibaba:mainfrom
Open
Conversation
Add return type annotations to 10 functions in functionals.py: - union_two_dict() -> Dict - append_to_dict() -> None - compute_clip_fraction() -> float - entropy_from_logits() -> torch.Tensor - agg_loss() -> torch.Tensor - get_eos_mask() -> torch.Tensor - get_pad_mask() -> torch.Tensor - masked_whiten() -> torch.Tensor - response_level_masked_whiten() -> torch.Tensor - pad_to_length() -> torch.Tensor Other improvements: - Add complete parameter types to pad_to_length - Translate Chinese comments to English - Improve docstrings with Args, Returns, Examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds return type annotations to 10 utility functions that had parameter types but were missing return types.
Testing
Related
Part of type hints improvement for roll/utils/functionals.py.
Follow-up to #387