Open
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Review Summary by QodoRelease version 0.1.1 across all components
WalkthroughsDescription• Update project version from 0.1.0 to 0.1.1 • Update CLI tool version string to 0.1.1 • Update all Docker image references to v0.1.1 • Update Python package version and build configuration • Update documentation and workflow examples Diagramflowchart LR
A["Version 0.1.0"] -->|Update| B["Version 0.1.1"]
B -->|Applied to| C["CLI Tool"]
B -->|Applied to| D["Python Package"]
B -->|Applied to| E["Docker Images"]
B -->|Applied to| F["Documentation"]
B -->|Applied to| G["CI/CD Workflows"]
File Changes1. tools/python_bind/neug_cli.py
|
Code Review by Qodo
1. Double v breaks extensions
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
64
to
+68
| elif [ -n "${{ github.ref }}" ] && [[ "${{ github.ref }}" == refs/tags/* ]]; then | ||
| VERSION="${GITHUB_REF#refs/tags/}" | ||
| else | ||
| # Default to 0.1.0 if no version is specified | ||
| VERSION="0.1.0" | ||
| # Default to 0.1.1 if no version is specified | ||
| VERSION="0.1.1" |
There was a problem hiding this comment.
1. Double v breaks extensions 🐞 Bug ≡ Correctness
.github/workflows/build-extensions.yml can derive VERSION from a git tag like v0.1.1 and pass
it into build_and_upload_extensions.sh, which constructs OSS paths as
neug/extensions/v{version}/..., producing neug/extensions/vv0.1.1/.... The C++ extension
downloader formats URLs with exactly one v prefix and NEUG_VERSION (e.g., 0.1.1), so uploaded
artifacts under vv0.1.1 will not be found at runtime.
Agent Prompt
## Issue description
The extension upload pipeline can produce incorrect OSS paths like `neug/extensions/vv0.1.1/...` because the workflow may pass a tag name that already starts with `v` (e.g., `v0.1.1`) into a script that unconditionally prefixes paths with `v{version}`.
## Issue Context
Runtime extension downloads use `NEUG_VERSION` (e.g., `0.1.1`) and repository templates that already include a single leading `v` (e.g., `v{}/{}/{}/...`). Therefore, uploaded artifacts must live under `.../v0.1.1/...`, not `.../vv0.1.1/...`.
## Fix Focus Areas
- Strip a leading `v` when deriving `VERSION` from tags (and ideally also when accepting `--version` in the script) so both tag-based and manual invocations are safe.
- Update script help/examples to show the normalized version format (e.g., `0.1.1`), to avoid reintroducing the problem via copy/paste.
### Code locations
- .github/workflows/build-extensions.yml[59-71]
- .github/workflows/build-extensions.yml[137-145]
- scripts/build_and_upload_extensions.sh[16-35]
- scripts/build_and_upload_extensions.sh[227-266]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Collaborator
Author
NeuG v0.1.1 Release NotesVersion: 0.1.1 New Features
Bug Fixes
Refactoring
CI/CD
Documentation
Tests
NeuG v0.1.1 Release Notes版本: 0.1.1 New Features
Bug Fixes
Refactoring
CI/CD
Documentation
Tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #138