fix(background-file) Manage path at git repository root directory Ref…#327
Open
Victor-D wants to merge 1 commit into
Open
fix(background-file) Manage path at git repository root directory Ref…#327Victor-D wants to merge 1 commit into
Victor-D wants to merge 1 commit into
Conversation
Contributor
|
✅ OpenCodeReview: No comments generated. Looks good to me. |
lizhengfeng101
left a comment
Collaborator
There was a problem hiding this comment.
Nice fix! The implementation is clean and minimal — resolveBackgroundFilePath handles the three cases (empty, absolute, relative) correctly, and the test coverage is solid with both unit tests and an end-to-end scenario.
One suggestion: could you add a test case for when repoDir is an empty string? This would happen if --repo is not specified and repo detection fails. In that case filepath.Join("", relativePath) returns the relative path as-is, which is a reasonable fallback to the old behavior — but it would be good to have an explicit test documenting that expectation.
Other than that, LGTM. Thanks for the contribution!
3622f36 to
37e1ecb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix(background-file) Manage path at git repository root directory
Type of Change
How Has This Been Tested?
make testpasses locallyQuick tests such as
./dist/opencodereview review --repo $PWD -B ./../../../../misc/ocr/mycontext.mdwere doneChecklist
go fmt,go vet)Related Issues
closes #324
#324