Skip to content

Update Python version in workflow to 3.10#186

Merged
Cuiyus merged 1 commit intomainfrom
Cuiyus-patch-1
Feb 28, 2026
Merged

Update Python version in workflow to 3.10#186
Cuiyus merged 1 commit intomainfrom
Cuiyus-patch-1

Conversation

@Cuiyus
Copy link
Collaborator

@Cuiyus Cuiyus commented Feb 28, 2026

No description provided.

@Cuiyus Cuiyus merged commit 120d9e3 into main Feb 28, 2026
4 checks passed
@Cuiyus Cuiyus deleted the Cuiyus-patch-1 branch February 28, 2026 06:39
@greptile-apps
Copy link

greptile-apps bot commented Feb 28, 2026

Greptile Summary

This PR removes Python 3.13 and 3.14 from the CI test matrix, reversing the support added in PR #164. However, this creates a critical inconsistency in the project configuration.

Major Issues:

  • pyproject.toml still declares support for Python 3.13 and 3.14 in classifiers (lines 30-31)
  • cibuildwheel configuration still builds wheels for cp313 and cp314 (lines 166-167)
  • CI will only test Python 3.10, but wheels will be distributed for Python 3.11-3.14 without testing
  • The requires-python = ">=3.9" declaration means Python 3.9, 3.11, and 3.12 are also untested

Recommendation:
Either revert this change to continue testing Python 3.13/3.14, or update pyproject.toml and cibuildwheel configuration to match the reduced CI scope. The current state risks shipping broken packages to users on Python 3.11-3.14.

Confidence Score: 0/5

  • Not safe to merge - creates critical configuration inconsistency that will result in untested code being distributed
  • The PR creates a dangerous mismatch between CI testing (Python 3.10 only) and package distribution (builds wheels for Python 3.10-3.14). This means users installing on Python 3.11, 3.12, 3.13, or 3.14 will receive untested wheels that could be broken. Additionally, Python 3.9 support is declared but never tested.
  • .github/workflows/main.yml requires either reverting this change or updating pyproject.toml and tool.cibuildwheel.build to match the reduced Python version scope

Important Files Changed

Filename Overview
.github/workflows/main.yml Removes Python 3.13 and 3.14 from CI test matrix, creating inconsistency with package metadata that still declares support for these versions

Last reviewed commit: e356e94

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

fail-fast: false
matrix:
python-version: ['3.10', '3.13', '3.14']
python-version: ['3.10']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing Python 3.13 and 3.14 from CI creates inconsistency with pyproject.toml (lines 30-31) which still declares support for these versions, and cibuildwheel config (lines 166-167) which still builds wheels for them. This means Python 3.11-3.14 wheels will be distributed but not tested in CI.

Either:

  1. Keep testing 3.13 and 3.14 in CI (revert this change), OR
  2. Remove them from pyproject.toml classifiers and cibuildwheel config too
Suggested change
python-version: ['3.10']
python-version: ['3.10', '3.11', '3.12', '3.13', '3.14']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant