Rework run_server endpoint argument to evade issues with colon#450
Open
grossjct wants to merge 2 commits intoallenai:mainfrom
Open
Rework run_server endpoint argument to evade issues with colon#450grossjct wants to merge 2 commits intoallenai:mainfrom
grossjct wants to merge 2 commits intoallenai:mainfrom
Conversation
…th to evade the issue of using a colon in an argument, which is not compatible with the argument seperation using a colon as seperator
There was a problem hiding this comment.
Pull request overview
This PR updates the server benchmark runner configuration to avoid using a colon-containing endpoint argument (which conflicts with olmocr.bench.convert’s colon-delimited method[:key=value...] parsing), by splitting the endpoint into separate components.
Changes:
- Replaces the single
endpointargument withendpoint_scheme,endpoint_hostname,endpoint_port, andendpoint_path. - Constructs the full endpoint URL from the new components inside
run_server.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #445
Changes proposed in this pull request:
Before submitting
section of the
CONTRIBUTINGdocs.Writing docstrings section of the
CONTRIBUTINGdocs.