Skip to content

Rework run_server endpoint argument to evade issues with colon#450

Open
grossjct wants to merge 2 commits intoallenai:mainfrom
grossjct:fix/issue-445
Open

Rework run_server endpoint argument to evade issues with colon#450
grossjct wants to merge 2 commits intoallenai:mainfrom
grossjct:fix/issue-445

Conversation

@grossjct
Copy link
Copy Markdown

@grossjct grossjct commented Apr 1, 2026

Fixes #445

Changes proposed in this pull request:

  • Split the endpoint argument of run_server into 4 arguments for each part
  • Avoids the need of a colon in the arguments
  • This evades the issue of the colon being the seperator for the method arguments, which makes it not usable in an argument

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

…th to evade the issue of using a colon in an argument, which is not compatible with the argument seperation using a colon as seperator
Copilot AI review requested due to automatic review settings April 1, 2026 15:38
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the server benchmark runner configuration to avoid using a colon-containing endpoint argument (which conflicts with olmocr.bench.convert’s colon-delimited method[:key=value...] parsing), by splitting the endpoint into separate components.

Changes:

  • Replaces the single endpoint argument with endpoint_scheme, endpoint_hostname, endpoint_port, and endpoint_path.
  • Constructs the full endpoint URL from the new components inside run_server.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread olmocr/bench/runners/run_server.py Outdated
Comment thread olmocr/bench/runners/run_server.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unable to set endpoint argument in server method because of colon arg delimiter

2 participants