Skip to content

fix: Add missing numpy dependency#454

Open
grossjct wants to merge 1 commit intoallenai:mainfrom
grossjct:fix/issue-452
Open

fix: Add missing numpy dependency#454
grossjct wants to merge 1 commit intoallenai:mainfrom
grossjct:fix/issue-452

Conversation

@grossjct
Copy link
Copy Markdown

@grossjct grossjct commented Apr 7, 2026

Fixes #452

Changes proposed in this pull request:

  • add missing numpy dependency

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

Copilot AI review requested due to automatic review settings April 7, 2026 18:08
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the missing numpy dependency to the bench optional dependency group so olmocr.bench can be run without a ModuleNotFoundError (Fixes #452).

Changes:

  • Add numpy to [project.optional-dependencies].bench in pyproject.toml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

numpy is missing from [bench] dependencies

2 participants