Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a configurable HTTP client timeout to the olmocr bench “server” runner, addressing issue #455 where the previous fixed 300s timeout was insufficient for some use cases.
Changes:
- Add a
timeoutparameter (default300) torun_server(...). - Use the new
timeoutvalue when constructinghttpx.AsyncClient.
Comments suppressed due to low confidence (1)
olmocr/bench/runners/run_server.py:41
- Now that
timeoutis configurable, it would help to document its units/behavior in the docstring (e.g., seconds, passed through tohttpx.AsyncClient(timeout=...)). Also consider typing it asfloat(vsint) since httpx accepts floats and callers viaparse_method_argmay supply non-integer values.
timeout: int = 300,
) -> str:
"""
Convert page of a PDF file to markdown by calling a request
running against an openai compatible server.
You can use this for running against vllm, sglang, servers
as well as mixing and matching different model's.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #455
Changes proposed in this pull request: