fix: escape percent sign in argparse help string#457
Open
Bahtya wants to merge 1 commit intoallenai:mainfrom
Open
fix: escape percent sign in argparse help string#457Bahtya wants to merge 1 commit intoallenai:mainfrom
Bahtya wants to merge 1 commit intoallenai:mainfrom
Conversation
The help string for --confidence_level contains a literal '%' which argparse interprets as a format specifier, causing ValueError: 'unsupported format character C' on Python 3.14+. Escape '95% CI' to '95%% CI' to fix the help string formatting. Fixes allenai#451 Signed-off-by: bahtya <bahtyar153@qq.com>
Author
|
Hi team, just wanted to follow up on this PR. Would appreciate any feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
python -m olmocr.bench.benchmark --dir ...crashes with:The argparse help string for
--confidence_levelcontains95% CI. Python's argparse uses%-formatting for help strings, so the literal%is interpreted as a format specifier.Fix
Escape
95%to95%%in the help string.Fixes #451