Conversation
Introduce strict configuration validation and improve clarity of environment variable naming. - Implement Config.Validate() using jellydator/validation to ensure all settings are within valid ranges and do not conflict (e.g., SERVER_PORT vs METRICS_PORT). - Rename DB_CONN_MAX_LIFETIME to DB_CONN_MAX_LIFETIME_MINUTES to explicitly state the unit. - Rename SERVER_SHUTDOWN_TIMEOUT to SERVER_SHUTDOWN_TIMEOUT_SECONDS for consistency. - Add METRICS_PORT configuration (default: 8081). - Define default values as constants for better maintainability. - Update documentation and example files to match new configuration names. - Add comprehensive unit tests for configuration validation logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce strict configuration validation and improve clarity of environment variable naming.