Fix double-counting of occupied disk space#1103
Merged
Merged
Conversation
…ob releases its resources. The issue arises when the `Job` instance uses the same directory for its output and tmp directories. In the current implementation, this can happen when the `Job` has no explicit input, output, or tmp directory definition, and the `target` workdir is used for all of them.
LanderOtto
force-pushed
the
fix/double-count-size
branch
from
b02c631 to
464d019
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1103 +/- ##
===========================================
+ Coverage 0 64.18% +64.18%
===========================================
Files 0 93 +93
Lines 0 17570 +17570
Branches 0 2161 +2161
===========================================
+ Hits 0 11278 +11278
- Misses 0 6010 +6010
- Partials 0 282 +282 ☔ View full report in Codecov by Harness. |
…y indicate when a normalized instance is necessary. Additionally, fix the behavior of the `bind_mount_point` method, which was collapsing `Storage` without following the correct logic, leading to missing `Storage` info. Now, the bind method keeps the previous keys for the storages
LanderOtto
force-pushed
the
fix/double-count-size
branch
7 times, most recently
from
8b58b44 to
4e558e8
Compare
…ifying it in-place.
LanderOtto
force-pushed
the
fix/double-count-size
branch
from
4e558e8 to
6bc31d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the double-counting of occupied disk space when a job releases its resources. The issue arises when the
Jobinstance uses the same directory for its output and tmp directories. In the current implementation, this can happen when theJobinstance has no explicit values in itsinput,output, ortmpdirectory attributes, and thetargetworkdir is used for all of them. Added new test.Additionally, this commit fixes the behavior of the
bind_mount_pointmethod, which was collapsingStoragewithout following the correct logic, leading to missingStorageinfo. Improvedtest_bind_volumes.