feat: handle checkout order approved event#5
Open
ochicf wants to merge 1 commit intoalphabite-dev:mainfrom
Open
feat: handle checkout order approved event#5ochicf wants to merge 1 commit intoalphabite-dev:mainfrom
ochicf wants to merge 1 commit intoalphabite-dev:mainfrom
Conversation
This event gets triggered when the checkout of the order finishes. We can authorise the payment in Medusa so the order is created from the cart, and the payment process continues and gets eventually captured.
ochicf
force-pushed
the
feat/order-approved-event
branch
from
9737ee2 to
b0695d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to configure this plugin into my store, I found that after the checkout only the
CHECKOUT.ORDER.APPROVEDevent was triggered through the webhook, but thePAYMENT.CAPTURE.COMPLETEDwas never called.This PR handle the
CHECKOUT.ORDER.APPROVEDand authorizes the payment so Medusa invokes theauthorizePaymentmethod of the service. This does invoke thecaptureOrder, which eventually will trigger the other webhook to fully capture the payment.Maybe I'm missing something but this is the only way I found to fully capture the payment, so if this is not correct or expected please let me know.
EDIT: I forced push because I started from my fork's main instead of the upstream's, so originally the PR contained other changes. Sorry about that.