Bump keccak from 0.1.4 to 0.1.6 in /arbitrator/stylus/tests/math#5
Open
dependabot[bot] wants to merge 1 commit intomasterfrom
Open
Bump keccak from 0.1.4 to 0.1.6 in /arbitrator/stylus/tests/math#5dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
Bumps [keccak](https://github.com/RustCrypto/sponges) from 0.1.4 to 0.1.6. - [Commits](RustCrypto/sponges@keccak/v0.1.4...keccak-v0.1.6) --- updated-dependencies: - dependency-name: keccak dependency-version: 0.1.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
renlulu
suggested changes
Apr 28, 2026
renlulu
left a comment
There was a problem hiding this comment.
Review findings
[P1] Lockfile v4 drops declared Cargo/MSRV compatibility
The PR changes arbitrator/stylus/tests/math/Cargo.lock from lockfile format version = 3 to version = 4. That makes Cargo 1.67.1 and 1.73.0 fail before dependency resolution, while this repo still declares arbitrator rust-version 1.67 and the checked-out Stylus SDK workspace declares 1.71.0. Base parses with those older Cargo versions; this branch does not.
Please regenerate the lockfile with an MSRV-compatible Cargo, or explicitly raise the supported Rust/Cargo floor for this workspace. The keccak bump itself looked low risk under newer Cargo.
Validation run: Cargo metadata/checks across 1.67.1, 1.73.0, 1.80.1, and nightly; base/head comparison confirmed the lockfile-format regression is PR-introduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps keccak from 0.1.4 to 0.1.6.
Commits
a8936d9keccak v0.1.640c50c1keccak v0.1.5 (#69)2dc13bfkeccak: enable asm backend for p1600 (#68)a3a4e01Revert "Update Cargo.lock" (#67)3a9a29eUpdate Cargo.lock9e4f6bckeccak: don't testsimdfeature inminimal-versionsworkflow (#66)329d4cdReplace cross tests with MIRI (#63)48cc4acbuild(deps): bump actions/checkout from 3 to 4 (#61)651a34ekeccak: replace CI tests on MIPS with PPC32 (#62)4730c6fbenches: remove criterion deps workaround (#60)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.